uccser / cs-field-guide Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix simplifier improvements #1168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eAlasdair
requested changes
Oct 16, 2019
Good work
csfieldguide/static/interactives/scene-editor/js/scene-editor.js
Outdated
Show resolved
Hide resolved
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js
Outdated
Show resolved
Hide resolved
eAlasdair
reviewed
Oct 17, 2019
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js
Show resolved
Hide resolved
eAlasdair
approved these changes
Oct 17, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds ability for resulting equation in
matrix-simplifier
to be copied and pasted into all versions of thescene-editor
interactive.Adds ability to remove all equations in the
matrix-simplifier
interactive with one button click.Resolves #1115