Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix simplifier improvements #1168

Merged
merged 18 commits into from Oct 17, 2019
Merged

Matrix simplifier improvements #1168

merged 18 commits into from Oct 17, 2019

Conversation

@courtneycb
Copy link
Contributor

courtneycb commented Oct 16, 2019

  • Adds ability for resulting equation in matrix-simplifier to be copied and pasted into all versions of the scene-editor interactive.

  • Adds ability to remove all equations in the matrix-simplifier interactive with one button click.

Resolves #1115

@courtneycb courtneycb requested a review from eAlasdair Oct 16, 2019
@courtneycb courtneycb self-assigned this Oct 16, 2019
Copy link
Member

eAlasdair left a comment

Good work 👍 I think a few things can be done to polish it up a bit

courtneycb added 5 commits Oct 17, 2019
Copy link
Member

eAlasdair left a comment

Couple of minor things, then it'll be ready

@courtneycb courtneycb merged commit 296e09b into develop Oct 17, 2019
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing ace12a0...57640bb
Details
codecov/project 96.08% remains the same compared to ace12a0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@courtneycb courtneycb deleted the matrix-simplifier-improvements branch Oct 17, 2019
@JackMorganNZ JackMorganNZ mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.