Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentence about mesh points in CG chapter. #1170

merged 2 commits into from Oct 18, 2019


Copy link

@courtneycb courtneycb commented Oct 17, 2019

We now use an entirely different teapot mesh in the scene-editor interactive.The new mesh has 289 points instead of 3644. Have updated the sentence to match.

We do not know how many points there are exactly now. Unless someone knows how to calculate how many there are?

@courtneycb courtneycb requested a review from eAlasdair Oct 17, 2019
@courtneycb courtneycb self-assigned this Oct 17, 2019
eAlasdair previously approved these changes Oct 18, 2019
@eAlasdair eAlasdair dismissed their stale review Oct 18, 2019

Second guessing myself about the value

Copy link

@eAlasdair eAlasdair commented Oct 18, 2019

I got the value of 289 from counting the lines here. However, since there are a lot of circles in the teapot, there's a chance those circles are defined as position:radius instead, in which case the resulting mesh would have many more actual vertices

Now I suggest saying "many thousands" instead of defining a number

Copy link

@eAlasdair eAlasdair left a comment

That works

@courtneycb courtneycb merged commit ceee00c into develop Oct 18, 2019
5 checks passed
@courtneycb courtneycb deleted the mesh-points-correction branch Oct 18, 2019
@JackMorganNZ JackMorganNZ mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants