Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentence about mesh points in CG chapter. #1170

Merged
merged 2 commits into from Oct 18, 2019
Merged

Conversation

@courtneycb
Copy link
Contributor

courtneycb commented Oct 17, 2019

We now use an entirely different teapot mesh in the scene-editor interactive.The new mesh has 289 points instead of 3644. Have updated the sentence to match.

We do not know how many points there are exactly now. Unless someone knows how to calculate how many there are?

@courtneycb courtneycb requested a review from eAlasdair Oct 17, 2019
@courtneycb courtneycb self-assigned this Oct 17, 2019
@eAlasdair eAlasdair dismissed their stale review Oct 18, 2019

Second guessing myself about the value

@eAlasdair

This comment has been minimized.

Copy link
Member

eAlasdair commented Oct 18, 2019

I got the value of 289 from counting the lines here. However, since there are a lot of circles in the teapot, there's a chance those circles are defined as position:radius instead, in which case the resulting mesh would have many more actual vertices

Now I suggest saying "many thousands" instead of defining a number

Copy link
Member

eAlasdair left a comment

That works

@courtneycb courtneycb merged commit ceee00c into develop Oct 18, 2019
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing 0759a9d...368e3f4
Details
codecov/project 96.08% remains the same compared to 0759a9d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@courtneycb courtneycb deleted the mesh-points-correction branch Oct 18, 2019
@JackMorganNZ JackMorganNZ mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.