Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS code to open external links in a new tab #1175

Merged
merged 14 commits into from Oct 25, 2019

Conversation

aenkirch
Copy link
Contributor

@aenkirch aenkirch commented Oct 22, 2019

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request:

Changed different HTML files where I noticed external links.

Checklist

Change the space in the box to an x for those you have completed.
You can also fill these out after creating the pull request.
If you're unsure about any of them, don't hesitate to ask.
We're here to help!
This is simply a reminder of what we are going to look for before merging your change.

  • I have read the contribution guidelines.
  • I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number).
  • The pull request is requesting a merge into the develop branch.
  • I have added necessary documentation (if appropriate).
  • If I've added/modified/deleted a third-party system, I've updated the relevant license files.
  • I have added myself to the 'Community Contributors' section of csfieldguide/templates/appendices/contributors.html

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.
Feel free to add any images that might be helpful to understand the initial problem/solution.

Copy link
Collaborator

@eAlasdair eAlasdair left a comment

Thank you very much for your contribution!

This will not resolve the issue (#783) as there are more links in the markdown files - most of which need an internal change to fix. However your work is greatly appreciated. Please address these comments before we merge your changes.

csfieldguide/templates/appendices/contributors.html Outdated Show resolved Hide resolved
csfieldguide/templates/interactives/mips-assembler.html Outdated Show resolved Hide resolved
csfieldguide/templates/interactives/mips-assembler.html Outdated Show resolved Hide resolved
csfieldguide/templates/interactives/password-guesser.html Outdated Show resolved Hide resolved
@aenkirch
Copy link
Contributor Author

@aenkirch aenkirch commented Oct 24, 2019

@eAlasdair I resolved all the problems you mentioned in this commit aenkirch@c2c8469 ;)

Copy link
Collaborator

@eAlasdair eAlasdair left a comment

Thanks for your work

@eAlasdair eAlasdair merged commit 5935175 into uccser:develop Oct 25, 2019
3 checks passed
@JackMorganNZ JackMorganNZ mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants