Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default settings for split health checks. #1187

Merged
merged 2 commits into from Nov 19, 2019
Merged

Use default settings for split health checks. #1187

merged 2 commits into from Nov 19, 2019

Conversation

@courtneycb
Copy link
Contributor

courtneycb commented Nov 7, 2019

We are currently having issues where we cannot set a custom path under liveness_check or readiness_check (across all projects) and this is causing deployments to fail. We will revert to using the default split health check settings until we know more about the issue.

Info on default settings here: https://cloud.google.com/appengine/docs/flexible/custom-runtimes/migrating-to-split-health-checks#understanding_key_differences

By default split health checks only confirm that the VM instance and the Docker container are running. As long as these conditions hold, the VM will continue to receive traffic and remain alive regardless of the app's internal state.

@courtneycb courtneycb requested review from JackMorganNZ and eAlasdair Nov 7, 2019
@courtneycb courtneycb self-assigned this Nov 7, 2019
@eAlasdair

This comment has been minimized.

Copy link
Member

eAlasdair commented Nov 7, 2019

Does this include updating the dev site health checks? They are still the outdated ones

@courtneycb

This comment has been minimized.

Copy link
Contributor Author

courtneycb commented Nov 7, 2019

Does this include updating the dev site health checks? They are still the outdated ones

I have updated the health checks on the dev site using:
gcloud app update --split-health-checks --project cs-field-guide-dev

@courtneycb courtneycb merged commit 14495d5 into develop Nov 19, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 96.06% (-0.02%) compared to e62af4d
Details
codecov/patch Coverage not affected when comparing e62af4d...2a87dbc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@courtneycb courtneycb deleted the hc-default branch Nov 19, 2019
@courtneycb

This comment has been minimized.

Copy link
Contributor Author

courtneycb commented Nov 19, 2019

Codecov failed but got the approval from Jack to merge anyway.

@JackMorganNZ JackMorganNZ mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.