Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement suggested features for Sorting Algorithms interactive #1196

Merged
merged 28 commits into from Dec 4, 2019

Conversation

@eAlasdair
Copy link
Member

eAlasdair commented Nov 18, 2019

Resolves #972

  • Add URL parameters for data types to sort: sorted, almost, reverse and the default random
  • Use 'Points to heavier box' instead of heaviest
  • Add a URL parameter that lets users peek at the values being sorted
  • Improve consistency in JS code
  • Create a url configurator interactive for teachers to access the extra functionality
  • Add the configurator to a teacher panel in the content
    • (and get an author's approval of said panel)

SECOND Draft teacher panel, it is now an interactive:
image

The eye option in action:
image

@JackMorganNZ

This comment has been minimized.

Copy link
Member

JackMorganNZ commented Nov 20, 2019

I would be keen to see a simple URL creator in the teacher mode, allowing teachers to pick from options using HTML form elements and a URL is created below for them to possibly copy and send to students. Creating a query string is not simple (hence the long instructions) and would probably be harder once translated to other languages. Thoughts?

@eAlasdair

This comment has been minimized.

Copy link
Member Author

eAlasdair commented Nov 20, 2019

I would be keen to see a simple URL creator in the teacher mode, allowing teachers to pick from options using HTML form elements and a URL is created below for them to possibly copy and send to students. Creating a query string is not simple (hence the long instructions) and would probably be harder once translated to other languages. Thoughts?

Reminds me of the Packet Attack level creator. I think that's a better idea, though with only 2 options and the general 'for teachers' vibe I'm wondering if it should be an uninteractive so it doesn't show up in the interactives page

eAlasdair added 6 commits Nov 20, 2019
@eAlasdair eAlasdair marked this pull request as ready for review Nov 21, 2019
@eAlasdair eAlasdair requested review from courtneycb and caitlind Nov 21, 2019
@caitlind

This comment has been minimized.

Copy link
Contributor

caitlind commented Nov 21, 2019

I think it would be good if the eye icon was larger, it took me a moment to find it and I was confused about why I wasn't seeing the numbers. Or maybe have a picture of it on the teacher panel beside the checkbox, so you know what you are looking for when the interactive opens.

I'd like it if I could also click on the eye to make it stay open and let me see the numbers all the time, rather than having to hover over it every time.

@eAlasdair

This comment has been minimized.

Copy link
Member Author

eAlasdair commented Nov 21, 2019

I think it would be good if the eye icon was larger, it took me a moment to find it and I was confused about why I wasn't seeing the numbers. Or maybe have a picture of it on the teacher panel beside the checkbox, so you know what you are looking for when the interactive opens.

I'd like it if I could also click on the eye to make it stay open and let me see the numbers all the time, rather than having to hover over it every time.

I've added an icon symbol to the configurator, do you still think I should make it larger/more noticable?

I can't easily make the peek functionality constant all the time because when the user goes to drag the box they pick up either the box and not the number or vice versa (can't remember which). I could make it remain on until the user picks up a box? Or if needed I'll figure out how to join the box and number together

@caitlind

This comment has been minimized.

Copy link
Contributor

caitlind commented Nov 21, 2019

I've added an icon symbol to the configurator, do you still think I should make it larger/more noticable?

That looks really good, I think it's fine at that size.

I can't easily make the peek functionality constant all the time because when the user goes to drag the box they pick up either the box and not the number or vice versa (can't remember which). I could make it remain on until the user picks up a box? Or if needed I'll figure out how to join the box and number together

I think it's ok without the checkbox if it would be difficult. I think it would be a bit weird if they stayed visible and then disappeared when you picked one up, it might look like it's actually a bug or something. But it would be good to see it if that wouldn't be too annoying to implement.

@eAlasdair

This comment has been minimized.

Copy link
Member Author

eAlasdair commented Nov 21, 2019

Need to fix a bug when hiding the second row of boxes while images are in them

eAlasdair added 2 commits Nov 21, 2019
eAlasdair and others added 4 commits Nov 26, 2019
(for the interactives page)
Copy link
Contributor

courtneycb left a comment

Looking goooooooooooooood! Just some teeny tiny comments 🐅

courtneycb and others added 5 commits Dec 3, 2019
Copy link
Contributor

courtneycb left a comment

💯

@eAlasdair eAlasdair merged commit 9942f17 into develop Dec 4, 2019
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing b52635b...8bc522d
Details
codecov/project 96.06% remains the same compared to b52635b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@eAlasdair eAlasdair deleted the issue/972/suggestions branch Dec 4, 2019
@JackMorganNZ JackMorganNZ mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.