Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text output and efficiency calculation to LZSS interactive #1285

Merged
merged 8 commits into from Jun 30, 2020

Conversation

eAlasdair
Copy link
Collaborator

@eAlasdair eAlasdair commented Jun 29, 2020

Related to #1253

  • Add encoded message output in textual form
  • Add display of unencoded message size and approximate encoded message size
  • Functionality to include the number of reference flags in the encoding size calculation exists, but commented out as I thought it would confuse users
    image

@courtneycb
Copy link
Contributor

courtneycb commented Jun 29, 2020

Has Tim looked at this?

@eAlasdair
Copy link
Collaborator Author

eAlasdair commented Jun 29, 2020

Has Tim looked at this?

Yes we discussed it, including the change in direction of the reference in the content

Copy link
Contributor

@courtneycb courtneycb left a comment

Partial review done. Submitting what I have so far and will take another look after my physio appointment.

Nice work though!

@courtneycb
Copy link
Contributor

courtneycb commented Jun 29, 2020

Not related to this PR but is there a reason why the lzssAlgorithm.js file is camel case?

@eAlasdair
Copy link
Collaborator Author

eAlasdair commented Jun 29, 2020

Not related to this PR but is there a reason why the lzssAlgorithm.js file is camel case?

Because heapsAlgorithm.js (city trip) is camelcase, but I created that file too so... no

Copy link
Contributor

@courtneycb courtneycb left a comment

Awesome work! 🎉

@eAlasdair eAlasdair merged commit 560f8e7 into develop Jun 30, 2020
5 checks passed
@eAlasdair eAlasdair deleted the lzss-features branch Jun 30, 2020
@courtneycb courtneycb mentioned this pull request Jun 30, 2020
@uccser-bot uccser-bot mentioned this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants