Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special brightness mode to Pixel Viewer #1300

merged 2 commits into from Jul 29, 2020


Copy link

The mode is accessed with parameters ?mode=brightness&colour-code=brightness. It cannot be accessed in any other way

?mode=brightness sets the pixels to greyscale, sets the description and doesn't add the thresholder.

?colour-code=brightness only activates if mode==brightness.
It sets the values displayed to be the R component of the colour (it's greyscale so this is fine), and it hides the colour format radio buttons as well as the config selector.

Optionally &picturepicker can be added to include the extra default pictures


@eAlasdair eAlasdair self-assigned this Jul 28, 2020
Copy link

@courtneycb courtneycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🎉

@eAlasdair eAlasdair merged commit c88d00c into develop Jul 29, 2020
5 checks passed
@eAlasdair eAlasdair deleted the pixel-viewer/brightness branch July 29, 2020 02:52
@JackMorganNZ JackMorganNZ mentioned this pull request Aug 1, 2020
@uccser-bot uccser-bot mentioned this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

2 participants