Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pixelmania-related features to Pixel Viewer #1304

Merged
merged 4 commits into from Jul 30, 2020
Merged

Conversation

eAlasdair
Copy link
Contributor

@eAlasdair eAlasdair commented Jul 30, 2020

Resolves #1302

  • Add new optional URL parameters:
    • hide-colour-code-picker - Full implementation of previous functionality to hide the radio options for colour code
    • hide-config-selector - Full implemetation of previous functionality to hide the configuration selector
    • pixelmania - Shows a small Pixelmania logo above the title in the menu
  • Add lake image to selection options, resized to 400px wide for visual effect on page load. Image is called lake.png regarding use in url parameters
  • Remove duplicate roof image from options
  • Add Brightness (average) option as a colour code to avoid mode-error and compatibility bugs. It now properly calculates the average of all three rgb values and as such can be used in colour also

These are the parameters to use for Pixelmania:
?mode=brightness&colour-code=brightness&image=lake.png&hide-colour-code-picker&hide-config-selector&pixelmania

Plus &picturepicker if desired

Copy link
Contributor

@courtneycb courtneycb left a comment

Awesome work!

@eAlasdair eAlasdair merged commit abcc480 into develop Jul 30, 2020
5 checks passed
@eAlasdair eAlasdair deleted the issue/1302 branch Jul 30, 2020
@JackMorganNZ JackMorganNZ mentioned this pull request Aug 1, 2020
@uccser-bot uccser-bot mentioned this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add new attributes to Pixel Viewer interactive
2 participants