Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new depth from stereo vision interactive #1375

merged 28 commits into from Aug 13, 2021


Copy link

@jqi26 jqi26 commented Apr 22, 2021

Proposed changes

I have created a new interactive that allows students to upload two stereo images, select the common point in both images, and then calculate the distance to that point. The user must also supply the angle-of-view of the camera and the distance between the camera positions. Currently, no links have been created, so that the only way to get to the interactive is via the URL. The new subsection has also not been written yet. Both of these will be added in the near future.



Change the space in the box to an x for those you have completed.
You can also fill these out after creating the pull request.
If you're unsure about any of them, don't hesitate to ask.
We're here to help!
This is simply a reminder of what we are going to look for before merging your change.

  • I have read the contribution guidelines.
  • I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number).
  • The pull request is requesting a merge into the develop branch.
  • I have added necessary documentation (if appropriate).
  • If I've added/modified/deleted a third-party system, I've updated the relevant license files.
  • I have added myself to the 'Community Contributors' section of csfieldguide/templates/appendices/contributors.html

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.
Feel free to add any images that might be helpful to understand the initial problem/solution.

jqi26 added 25 commits April 11, 2021 20:32
…mplementing the html template, but the two images do not appear as intended yet. Also added two images for testing.
…vas to respond to the clicks instead of the image.
…. However, scrolling affects the click coordinates as I am still figuring out how to get the scroll amount.
…wise an appropriate alert is created. Added collapsable instructions. Changed some text to make more sense in a mobile view.
…ves very similar results. Modified the html to use the full angle-of-view instead of the half angle-of-view.
… and right objects to collect them together to help with refactoring.
… guidelines. Made some minor stylistic changes to some of the inputs.
- Instructions now display by default and show the equation used.
- Variables now have the corresponding equation term next to them.
- Added option to change between inches and metres for the distance between pictures. Automatically converts the value in the box.
- The image widths are now shown.
- Improved the display of the angle-of-view and distance between pictures inputs in mobile.
…of view. May make additional styling additions. Embedded the interactive in depth section.
… the interactive JavaScript. Added a curiosity panel to the section. Filled out the READMEs for the two interactives.
Copy link

@JackMorganNZ JackMorganNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing Jackie, just a few minor tweaks are will be good to go.

- angle-of-view-calculator.html: Updated the text and id of the submit button.
- angle-of-view-calculator.js: Updated to use the new id.
- distance-from-stereo-images.html: Updated the text and id of the submit button.
- distance-from-stereo-images.js: Updated to use the new id.
- stereo.drawio: Added the file for the diagram.
- Modified according to the new diagram file.
- distance-from-stereo-images.html: Changed the images to use the new source. Wording changes.
@JackMorganNZ JackMorganNZ merged commit a404403 into uccser:develop Aug 13, 2021
@JackMorganNZ JackMorganNZ mentioned this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants