Added a new depth from stereo vision interactive #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplementing the html template, but the two images do not appear as intended yet. Also added two images for testing.
…ctionality to be able to select the images.
…with the canvas and image.
…vas to respond to the clicks instead of the image.
…. However, scrolling affects the click coordinates as I am still figuring out how to get the scroll amount.
… issues with scrolling.
…ulate the distance.
…wise an appropriate alert is created. Added collapsable instructions. Changed some text to make more sense in a mobile view.
…ves very similar results. Modified the html to use the full angle-of-view instead of the half angle-of-view.
…ns in distance-from-stereo-images.js.
… and right objects to collect them together to help with refactoring.
…he remaining methods.
… guidelines. Made some minor stylistic changes to some of the inputs.
- Instructions now display by default and show the equation used. - Variables now have the corresponding equation term next to them. - Added option to change between inches and metres for the distance between pictures. Automatically converts the value in the box. - The image widths are now shown. - Improved the display of the angle-of-view and distance between pictures inputs in mobile.
…of view. May make additional styling additions. Embedded the interactive in depth section.
… the interactive JavaScript. Added a curiosity panel to the section. Filled out the READMEs for the two interactives.
JackMorganNZ
requested changes
Aug 11, 2021
csfieldguide/static/interactives/distance-from-stereo-images/README.md
Outdated
Show resolved
Hide resolved
csfieldguide/templates/interactives/distance-from-stereo-images.html
Outdated
Show resolved
Hide resolved
csfieldguide/templates/interactives/distance-from-stereo-images.html
Outdated
Show resolved
Hide resolved
csfieldguide/templates/interactives/angle-of-view-calculator.html
Outdated
Show resolved
Hide resolved
- angle-of-view-calculator.html: Updated the text and id of the submit button. - angle-of-view-calculator.js: Updated to use the new id. - distance-from-stereo-images.html: Updated the text and id of the submit button. - distance-from-stereo-images.js: Updated to use the new id. - stereo.drawio: Added the file for the diagram. - README.md: Modified according to the new diagram file.
- distance-from-stereo-images.html: Changed the images to use the new source. Wording changes.
JackMorganNZ
approved these changes
Aug 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I have created a new interactive that allows students to upload two stereo images, select the common point in both images, and then calculate the distance to that point. The user must also supply the angle-of-view of the camera and the distance between the camera positions. Currently, no links have been created, so that the only way to get to the interactive is via the URL. The new subsection has also not been written yet. Both of these will be added in the near future.
Checklist
Change the space in the box to an
xfor those you have completed.You can also fill these out after creating the pull request.
If you're unsure about any of them, don't hesitate to ask.
We're here to help!
This is simply a reminder of what we are going to look for before merging your change.
#???in your description to reference an issue, where???is the issue number).developbranch.csfieldguide/templates/appendices/contributors.htmlFurther comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.
Feel free to add any images that might be helpful to understand the initial problem/solution.