Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix typos in Formal Languages chapter #385
Merged
Conversation
As there are four detailed following that sentence.
Helps the inputs stand out from text, and in keeping with the rest of the surrounding text.
If "a" must be followed by "b", then "bbb" would not be accepted, whereas "abb" (already listed) and "bab" would be accepted. So, changed "bbb" to "bab".
The double quotes inside the text end up ending the definition early, truncating the output. This might not be an ideal fix, but at least makes the text display for now.
StevenMaude
changed the title
|
Thanks so much @StevenMaude for your hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request:
Fixes small typos in the Formal Languages chapter.
Additionally, makes the glossary entry for Finite State Automaton display correctly.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the pull request. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your change.#???in your description to reference an issue, where???is the issue number)Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. Feel free to add any images that might be helpful to understand the initial problem/solution.
The fix for making the Finite State Automaton glossary entry display was to switch double quotes to single inside the definition, which might not be quite as you'd like. However, there doesn't seem to be a way to escape the double quote, it's treated as ending the glossary definition early, so seemed preferable in that it at least makes all the text appear for now.