Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive/high score boxes #390



Copy link

@thevictorchang thevictorchang commented Oct 8, 2016

Proposed changes

All bugs that were found during the EDEM session have been fixed, including:

  • Firefox compatibility
  • All numbers being revealed on dragging (disable dragging)
  • Range of random numbers is different each time now (to stop users "guessing" on repeated playthroughs
  • Added some new box images so users don't attempt to relate any of them together
  • boxes go greyscale on click (so users know which ones have been clicked)


Put an x in the boxes that apply. You can also fill these out after creating the pull request. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your change.

  • I have read the contribution guidelines
  • I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number)
  • I have applied the relevant labels for this change
  • I have run the generation script and checked the output
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. Feel free to add any images that might be helpful to understand the initial problem/solution.

Copy link

@JackMorganNZ JackMorganNZ left a comment

These changes look great @thevictorchang!

@JackMorganNZ JackMorganNZ merged commit 6df0254 into uccser:develop Oct 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@JackMorganNZ JackMorganNZ mentioned this pull request Oct 10, 2016
2 of 7 tasks complete
Copy link

@JackMorganNZ JackMorganNZ commented Oct 11, 2016

Hey @thevictorchang, this PR doesn't include the new images! Can you please create a new PR with them, or send them to me by email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.