New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle digits in 2d-arrow-manipulation config name #404

Merged
merged 1 commit into from Feb 15, 2017

Conversation

3 participants
@Goldob
Contributor

Goldob commented Feb 10, 2017

There is a bug in 2d-arrow-manipulations interactive that occurs when using config names including digits, e.g. matrix-scale-translate-2. It is caused by a faulty regex that matches incomplete label and makes the script look for a non-existent config file.

This PR fixes that.

@JackMorganNZ

This comment has been minimized.

Show comment
Hide comment
@JackMorganNZ

JackMorganNZ Feb 10, 2017

Member

Thanks @Goldob, looks great at first glance. Will check it properly and merge if all working when we return to work next week. 😄

Member

JackMorganNZ commented Feb 10, 2017

Thanks @Goldob, looks great at first glance. Will check it properly and merge if all working when we return to work next week. 😄

@hayleyavw hayleyavw merged commit 05183b9 into uccser:develop Feb 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hayleyavw

This comment has been minimized.

Show comment
Hide comment
@hayleyavw

hayleyavw Feb 16, 2017

Member

Thanks for that! :)

Member

hayleyavw commented Feb 16, 2017

Thanks for that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment