Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle digits in 2d-arrow-manipulation config name #404

Merged
merged 1 commit into from Feb 15, 2017

Conversation

@Goldob
Copy link
Contributor

@Goldob Goldob commented Feb 10, 2017

There is a bug in 2d-arrow-manipulations interactive that occurs when using config names including digits, e.g. matrix-scale-translate-2. It is caused by a faulty regex that matches incomplete label and makes the script look for a non-existent config file.

This PR fixes that.

@JackMorganNZ
Copy link
Member

@JackMorganNZ JackMorganNZ commented Feb 10, 2017

Thanks @Goldob, looks great at first glance. Will check it properly and merge if all working when we return to work next week. 😄

@hayleycodes hayleycodes merged commit 05183b9 into uccser:develop Feb 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hayleycodes
Copy link
Member

@hayleycodes hayleycodes commented Feb 16, 2017

Thanks for that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.