Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Representation Topic #1225

Merged
merged 28 commits into from Sep 2, 2019
Merged

Image Representation Topic #1225

merged 28 commits into from Sep 2, 2019

Conversation

@caitlind
Copy link
Contributor

caitlind commented Jul 22, 2019

Adds the new Image Representation topic.
Includes:

  • Unit Plan
  • Lesson 1, Colour by numbers, for ages 5-7 and 8-10 students
caitlind added 17 commits Jun 6, 2019
…r the Image Representation topic. Added the Image Representation topic to structure.yaml
…ding content to these.Added note about completing the binary numbers lesson first to the ima-rep introduction
…author review. Lesson content requires issue #1220 to be merged, otherwise it is innacurate where the pixel painter instructions are given.
Copy link
Member

JackMorganNZ left a comment

Great to see some new content. Various queries throughout, I didn't check the content of the PR (that's for @timbellnz), and it would be great to get @eAlasdair to review the content also (he's amazing with grammar/structure).

Also is csunplugged/static/img/topics/a_in_binary_code.png used anywhere?

@caitlind caitlind requested a review from eAlasdair Jul 22, 2019
caitlind added 6 commits Jul 22, 2019
…mage removed from img/topics
… wording to clarify the meaning
Copy link
Member

eAlasdair left a comment

As requested, I've looked through the PR for content/grammar/spelling. Because I don't know the project it's much harder to say one way is definitely correct over the other - so I'm leaving all of this as comments rather than requesting changes. Feel free to ignore anything that would be inconsistent, but otherwise, really good work! The explanations themselves are really easy to understand

@caitlind caitlind removed the request for review from timbellnz Jul 25, 2019
Copy link
Member

eAlasdair left a comment

👍

@caitlind caitlind merged commit 16f12af into develop Sep 2, 2019
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing 2d1238d...50792b7
Details
codecov/project 100% remains the same compared to 2d1238d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@JackMorganNZ JackMorganNZ deleted the content/image-rep branch Dec 16, 2019
@JackMorganNZ JackMorganNZ mentioned this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.