Image Representation Topic #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the Image Representation topic. Added the Image Representation topic to structure.yaml
…ding content to these.Added note about completing the binary numbers lesson first to the ima-rep introduction
…author review. Lesson content requires issue #1220 to be merged, otherwise it is innacurate where the pixel painter instructions are given.
caitlind
added
content: topics/unit plans/lessons
author
JackMorganNZ
requested changes
Jul 22, 2019
Great to see some new content. Various queries throughout, I didn't check the content of the PR (that's for @timbellnz), and it would be great to get @eAlasdair to review the content also (he's amazing with grammar/structure).
Also is csunplugged/static/img/topics/a_in_binary_code.png used anywhere?
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Show resolved
Hide resolved
eAlasdair
reviewed
Jul 23, 2019
As requested, I've looked through the PR for content/grammar/spelling. Because I don't know the project it's much harder to say one way is definitely correct over the other - so I'm leaving all of this as comments rather than requesting changes. Feel free to ignore anything that would be inconsistent, but otherwise, really good work! The explanations themselves are really easy to understand
csunplugged/topics/content/en/image-representation/image-representation.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/image-representation.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/image-representation.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/unit-plan.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/unit-plan.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/unit-plan.md
Outdated
Show resolved
Hide resolved
…ith a 'C' character
JackMorganNZ
approved these changes
Sep 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds the new Image Representation topic.
Includes: