uccser / cs-unplugged Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Representation Topic #1225
Conversation
…r the Image Representation topic. Added the Image Representation topic to structure.yaml
…ding content to these.Added note about completing the binary numbers lesson first to the ima-rep introduction
…author review. Lesson content requires issue #1220 to be merged, otherwise it is innacurate where the pixel painter instructions are given.
Great to see some new content. Various queries throughout, I didn't check the content of the PR (that's for @timbellnz), and it would be great to get @eAlasdair to review the content also (he's amazing with grammar/structure).
Also is csunplugged/static/img/topics/a_in_binary_code.png
used anywhere?
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Show resolved
Hide resolved
As requested, I've looked through the PR for content/grammar/spelling. Because I don't know the project it's much harder to say one way is definitely correct over the other - so I'm leaving all of this as comments rather than requesting changes. Feel free to ignore anything that would be inconsistent, but otherwise, really good work! The explanations themselves are really easy to understand
csunplugged/topics/content/en/image-representation/image-representation.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/image-representation.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/image-representation.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/lessons/colour-by-numbers.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/unit-plan.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/unit-plan.md
Outdated
Show resolved
Hide resolved
csunplugged/topics/content/en/image-representation/unit-plan/unit-plan.md
Outdated
Show resolved
Hide resolved
…ith a 'C' character
Adds the new Image Representation topic.
Includes: