New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure resource options #701

Merged
merged 50 commits into from Nov 23, 2017

Conversation

2 participants
@jordangriffiths01
Contributor

jordangriffiths01 commented Nov 22, 2017

No description provided.

jordangriffiths01 added some commits Nov 20, 2017

Update resource template to remove local generation options
These are now defined in the generator class
Removing redundant resource views tests
Smoke tests for all parameter values are now run in the generator tests.
PDF creation is tested in remaining view test modules.

@jordangriffiths01 jordangriffiths01 requested a review from JackMorganNZ Nov 22, 2017

@codecov

This comment has been minimized.

codecov bot commented Nov 22, 2017

Codecov Report

Merging #701 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #701      +/-   ##
===========================================
+ Coverage    99.37%   99.42%   +0.04%     
===========================================
  Files           92       97       +5     
  Lines         2869     3114     +245     
  Branches       352      372      +20     
===========================================
+ Hits          2851     3096     +245     
  Misses           8        8              
  Partials        10       10
Impacted Files Coverage Δ
csunplugged/resources/models.py 100% <100%> (ø) ⬆️
...rces/generators/SortingNetworkResourceGenerator.py 100% <100%> (ø) ⬆️
...es/generators/BinaryToAlphabetResourceGenerator.py 100% <100%> (ø) ⬆️
...ged/resources/management/commands/makeresources.py 100% <100%> (ø) ⬆️
...rces/generators/SearchingCardsResourceGenerator.py 100% <100%> (ø) ⬆️
...unplugged/resources/utils/BaseResourceGenerator.py 100% <100%> (ø) ⬆️
csunplugged/resources/utils/get_options_html.py 100% <100%> (ø)
.../resources/management/commands/_ResourcesLoader.py 100% <100%> (ø) ⬆️
...generators/SortingNetworkCardsResourceGenerator.py 100% <100%> (ø) ⬆️
...sources/generators/BinaryCardsResourceGenerator.py 100% <100%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d5c71...78fd3d2. Read the comment docs.

@JackMorganNZ

So much better! You are brilliant for designing this, and the tests are now so good!

Lots of single quotes used too, but the world won't end if they stay there.

@@ -0,0 +1,3 @@
# Arrows
This resource contains printouts for geometry activities.

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Change to:

This resource contains different arrows for Kidbots activities.

@@ -0,0 +1,3 @@
# Left and Right Cards
This resource contains printouts for geometry activities.

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Change to:

This resource contains printouts for Kidbots activities.

# Parity Cards
This resource contains printouts for parity card activities. To use this resource:
- Print the PDF double sided.

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

The Markdown should look like:

This resource contains printouts for parity card activities. To use this resource:

-   Print the PDF double sided.
-   Printing on 120 gsm card also can be useful.
  
Each page contains 20 parity cards, so we recommend printing at least 2 pages of cards as 40 cards is a useful number for most activities.
@@ -0,0 +1,3 @@
# Piano Keys
This resource contains printouts for the Piano Keys activity

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Change to:

This resource contains printouts for the modulo activities.

@@ -0,0 +1,3 @@
# Searching Cards
This resource contains printouts for the Searching Cards activity

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Change to:

This resource contains printouts for searching algorithms activities.

@@ -0,0 +1,3 @@
# Train Stations
This resource contains printouts for the Train Stations activity

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Change to:

This resource contains printouts for the modulo activities.

@@ -0,0 +1,3 @@
# Treasure Hunt
This resource contains printouts for the Treasure Hunt activity

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Change to:

This resource contains printouts for searching algorithms activities.

self.assertIsInstance(option, ResourceParameter)
def test_process_requested_options_valid(self):
pass

This comment has been minimized.

@JackMorganNZ

JackMorganNZ Nov 22, 2017

Member

Four empty tests here?

@jordangriffiths01 jordangriffiths01 merged commit 58fd6af into develop Nov 23, 2017

5 checks passed

codecov/patch 100% of diff hit (target 99.37%)
Details
codecov/project 99.42% (+0.04%) compared to b8d5c71
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@JackMorganNZ JackMorganNZ deleted the restructure-resource-options branch Nov 23, 2017

@JackMorganNZ JackMorganNZ referenced this pull request Dec 21, 2017

Merged

Release 2.0.0 Alpha 6 #766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment