Join GitHub today
Prepare images for 2.0 release #801
@@ Coverage Diff @@ ## develop #801 +/- ## ======================================== Coverage 99.54% 99.54% ======================================== Files 104 104 Lines 3272 3272 Branches 386 386 ======================================== Hits 3257 3257 Misses 7 7 Partials 8 8
Points are striked through when completed.
There is still changes to 'Printouts' in this PR, they need to be removed.
img/topics/col_binary_bite_vs_byte.pngis way too big on Binary Numbers Unit Plan (possibly 50% of current size).
img/topics/col_binary_01.pngis way too big on Binary Numbers Unit Plan (possibly 40% of current size).
img/topics/binary_cards_equals_three.pngin Binary Numbers has a different font size to the lightbulb images below it. Is it possible to shrink the font (not the whole image) to be closer?
img/topics/binary_torch.pngin Binary Numbers lesson panels could be right aligned as the image is not of high importance.
img/topics/binary_count_girl.pngin Binary Numbers panels is quite large it might not be obvious there is more text after it. Should we wrap the image or make it smaller?
img/topics/col_binary_necklace_copy.pngis too big to see the text below it, especially on mobile devices. It should be wrapped/made smaller and possibly after text.
img/topics/col_binary_cake.pngcould be right aligned.
img/topics/parity-cards.pngshould be right aligned with the relevant bullet point below it.
img/topics/parity-cards-6x6was this going to be turned into an animation?
img/topics/error-correction-paint-tin.pngI think this image could be improved as it still has a readable barcode on it, and possibly right aligned.
barcode-12images are inconsistent in two ways:
Operator symbols are sometimes coloured or grey (I think they should all be grey) Blue colour appears to be different across images.
img/topics/shannon-juggling.pngcould be right aligned.
img/topics/exercise-2.pngcould be right aligned.
img/topics/6_guesses.pngtext is too small to read.
img/topics/divide.pngchange into animal images as discussed.
img/topics/divide.pngdelete this image until we review the section.
img/topics/linear_search_chests.gifframerate of this animation is noticably lower than the previous animations and the sorted version (and also lower resolution). Could it be increase?
img/topics/where-is-my-hat.pngshould be right aligned due to it's height.
img/topics/sorting-network-comparing-apples.pngcould be right aligned.
img/topics/sorting-network-variation-alphabet.pngthe two cards at the back are different coloured.
Could the following images be redrawn to match the style of
referenced this pull request
Feb 1, 2018
Feb 5, 2018
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.