Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare images for 2.0 release #801

merged 41 commits into from Feb 5, 2018

Prepare images for 2.0 release #801

merged 41 commits into from Feb 5, 2018


Copy link

@saranglove saranglove commented Jan 23, 2018

This includes:

  • Resizing
  • Positioning
  • Subtitles (if required)
  • Image adjustments (like changing colours, change to animation etc).

Fixes #785.
Fixes #684.
Fixes #415.

Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #801 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #801   +/-   ##
  Coverage    99.54%   99.54%           
  Files          104      104           
  Lines         3272     3272           
  Branches       386      386           
  Hits          3257     3257           
  Misses           7        7           
  Partials         8        8
Impacted Files Coverage Δ
csunplugged/topics/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa0892...cb2effb. Read the comment docs.

@JackMorganNZ JackMorganNZ changed the title Issue/785 Prepare images for 2.0 release Jan 25, 2018
Copy link

@JackMorganNZ JackMorganNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points are striked through when completed.

  • There is still changes to 'Printouts' in this PR, they need to be removed.
  • img/topics/col_binary_bite_vs_byte.png is way too big on Binary Numbers Unit Plan (possibly 50% of current size).
  • img/topics/col_binary_01.png is way too big on Binary Numbers Unit Plan (possibly 40% of current size).
  • img/topics/binary_cards_equals_three.png in Binary Numbers has a different font size to the lightbulb images below it. Is it possible to shrink the font (not the whole image) to be closer?
  • img/topics/binary_torch.png in Binary Numbers lesson panels could be right aligned as the image is not of high importance.
  • img/topics/binary_count_girl.png in Binary Numbers panels is quite large it might not be obvious there is more text after it. Should we wrap the image or make it smaller?
  • img/topics/col_binary_necklace_copy.png is too big to see the text below it, especially on mobile devices. It should be wrapped/made smaller and possibly after text.
  • img/topics/col_binary_cake.png could be right aligned.
  • img/topics/parity-cards.png should be right aligned with the relevant bullet point below it.
  • img/topics/parity-cards-6x6 was this going to be turned into an animation?
  • img/topics/error-correction-paint-tin.png I think this image could be improved as it still has a readable barcode on it, and possibly right aligned.
  • The barcode-13 and barcode-12 images are inconsistent in two ways:
    • Operator symbols are sometimes coloured or grey (I think they should all be grey)
    • Blue colour appears to be different across images.
  • img/topics/shannon-juggling.png could be right aligned.
  • img/topics/exercise-2.png could be right aligned.
  • img/topics/6_guesses.png text is too small to read.
  • Images above img/topics/divide.png change into animal images as discussed.
  • img/topics/divide.png delete this image until we review the section.
  • img/topics/linear_search_chests.gif framerate of this animation is noticably lower than the previous animations and the sorted version (and also lower resolution). Could it be increase?
  • img/topics/where-is-my-hat.png should be right aligned due to it's height.
  • img/topics/sorting-network-comparing-apples.png could be right aligned.
  • img/topics/sorting-network-variation-alphabet.png the two cards at the back are different coloured.
  • Could the following images be redrawn to match the style of img/topics/sorting-network-variation-alphabet.png:
    • img/topics/sorting-network-variation-words.jpg
    • img/topics/sorting-network-variation-words-2.jpg
    • img/topics/sorting-network-variation-music.jpg

Copy link

Overall, it's a drastic improvement! The website is much easier to read and looks great at the same time. Quite a few small tweaks to make, but we are getting close.

img/topics/col_binary_bite_vs_byte.png is way too big on Binary Numbers
Unit Plan (possibly 50% of current size)
img/topics/col_binary_01.png is way too big on Binary Numbers Unit Plan
(possibly 40% of current size)
right align binary_torch
@JackMorganNZ JackMorganNZ merged commit cb2effb into develop Feb 5, 2018
@JackMorganNZ JackMorganNZ mentioned this pull request Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants