Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine and update changelogs #820

Merged
merged 1 commit into from Feb 2, 2018
Merged

Combine and update changelogs #820

merged 1 commit into from Feb 2, 2018

Conversation

@JackMorganNZ
Copy link
Member

@JackMorganNZ JackMorganNZ commented Feb 1, 2018

This pull request combines the Classic CS Unplugged changelog into the documentation, plus updates the version numbers to 4.0.0 to avoid confusion. The changelog for 4.0.0 will be written in the release branch.

@JackMorganNZ JackMorganNZ added this to the 4.0.0 milestone Feb 1, 2018
@JackMorganNZ JackMorganNZ self-assigned this Feb 1, 2018
@JackMorganNZ JackMorganNZ requested a review from hayleycodes Feb 1, 2018
@codecov
Copy link

@codecov codecov bot commented Feb 1, 2018

Codecov Report

Merging #820 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #820   +/-   ##
=======================================
  Coverage     99.5%   99.5%           
=======================================
  Files          102     102           
  Lines         3238    3238           
  Branches       383     383           
=======================================
  Hits          3222    3222           
  Misses           7       7           
  Partials         9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23aea7...a163bfd. Read the comment docs.

Copy link
Contributor

@hayleycodes hayleycodes left a comment

Will we be updating the our tags in git to avoid confusion between the changelog here and the changelog on github?

@JackMorganNZ
Copy link
Member Author

@JackMorganNZ JackMorganNZ commented Feb 2, 2018

GitHub tags and releases have been updated. You will need to run git pull --prune --tags to update your local repository.

@hayleycodes
Copy link
Contributor

@hayleycodes hayleycodes commented Feb 2, 2018

Ah when I last visited the releases page on github they were still on 2.0, I see this has now been updated, approved.

@JackMorganNZ JackMorganNZ merged commit a163bfd into develop Feb 2, 2018
5 checks passed
5 checks passed
@codecov
codecov/patch Coverage not affected when comparing b23aea7...a163bfd
Details
@codecov
codecov/project 99.5% remains the same compared to b23aea7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@JackMorganNZ JackMorganNZ deleted the issue/810-changelog branch Feb 5, 2018
@JackMorganNZ JackMorganNZ mentioned this pull request Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants