New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE/Edge browser compatibility features #824

Merged
merged 5 commits into from Feb 5, 2018

Conversation

2 participants
@JackMorganNZ
Member

JackMorganNZ commented Feb 2, 2018

  • Update details polyfill to 2.0.0
  • Increase contrast of details elements
    This is done for two reasons:
    • In IE/Edge browsers currently, the border is not shown therefore the background of the detail element should stand out from the page body.
    • Increased contrast for those with disabilities.
  • Fix for displaying images correcting in Internet Explorer
  • Add CSS styling to display detail elements better on IE/Edge

JackMorganNZ added some commits Feb 2, 2018

Increase contrast of details elements
This is done for two reasons:
  - In IE/Edge browsers currently, the border is not shown
    therefore the background of the detail element should
    stand out from the page body.
  - Increased contrast for those with disabilities.

@JackMorganNZ JackMorganNZ added this to the 4.0.0 milestone Feb 2, 2018

@JackMorganNZ JackMorganNZ self-assigned this Feb 2, 2018

@JackMorganNZ JackMorganNZ requested a review from hayleyavw Feb 2, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 2, 2018

Codecov Report

Merging #824 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #824      +/-   ##
===========================================
+ Coverage    99.53%   99.54%   +<.01%     
===========================================
  Files          102      104       +2     
  Lines         3258     3272      +14     
  Branches       386      386              
===========================================
+ Hits          3243     3257      +14     
  Misses           7        7              
  Partials         8        8
Impacted Files Coverage Δ
csunplugged/classic/views.py 100% <0%> (ø)
csunplugged/classic/urls.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e2388...dbff88b. Read the comment docs.

@hayleyavw

I am on a mac with no access to a windows machine at the moment. I have tested to make sure the panels still work as expected on my usual environment, but because I can't see for myself the result on Edge, hesitant to approve this PR...maybe post a screenshot of the result in Edge to convince me?

@JackMorganNZ

This comment has been minimized.

Member

JackMorganNZ commented Feb 4, 2018

This is what is looked like before PR (IE left, Edge right):

image

This is what is looked like after PR (IE left, Edge right):

image

@JackMorganNZ JackMorganNZ merged commit dbff88b into develop Feb 5, 2018

5 checks passed

codecov/patch Coverage not affected when comparing a1e2388...dbff88b
Details
codecov/project 99.54% (+<.01%) compared to a1e2388
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@JackMorganNZ JackMorganNZ deleted the issue/810-browser-compatibility branch Feb 5, 2018

@JackMorganNZ JackMorganNZ referenced this pull request Feb 5, 2018

Merged

Release 4.0.0 #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment