New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all example classroom videos at appropriate positions #842

Merged
merged 2 commits into from Feb 5, 2018

Conversation

2 participants
@JackMorganNZ
Member

JackMorganNZ commented Feb 3, 2018

Locations were suggested by @timbellnz in private email.

Working on this raised issues #840 and #841.

@JackMorganNZ JackMorganNZ self-assigned this Feb 3, 2018

@JackMorganNZ JackMorganNZ requested a review from hayleyavw Feb 3, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 3, 2018

Codecov Report

Merging #842 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #842   +/-   ##
========================================
  Coverage    99.54%   99.54%           
========================================
  Files          104      104           
  Lines         3272     3272           
  Branches       386      386           
========================================
  Hits          3257     3257           
  Misses           7        7           
  Partials         8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce027b...6c03a93. Read the comment docs.

# See teaching this in action
A demonstration of sorting networks being taught is available here:

This comment has been minimized.

@hayleyavw

hayleyavw Feb 4, 2018

Member

should this line be removed for consistency?

# See teaching this in action
A demonstration of sorting networks being taught is available here:

This comment has been minimized.

@hayleyavw

hayleyavw Feb 4, 2018

Member

should this line be removed for consistency?

@JackMorganNZ JackMorganNZ merged commit 6c03a93 into develop Feb 5, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 0ce027b...6c03a93
Details
codecov/project 99.54% remains the same compared to 0ce027b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@JackMorganNZ JackMorganNZ deleted the sample-videos branch Feb 5, 2018

@JackMorganNZ JackMorganNZ referenced this pull request Feb 5, 2018

Merged

Release 4.0.0 #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment