Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments to navbar and homepage #885

Merged
merged 16 commits into from
Feb 15, 2018
Merged

Minor adjustments to navbar and homepage #885

merged 16 commits into from
Feb 15, 2018

Conversation

saranglove
Copy link
Contributor

@saranglove saranglove commented Feb 13, 2018

Slightly more space between the logo and 'Topics' on the navbar.
The search-box is vertically slightly smaller.
The navbar is transparent that goes opaque on scroll down on the homepage.

(fixes #878)

@codecov
Copy link

codecov bot commented Feb 13, 2018

Codecov Report

Merging #885 into develop will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
+ Coverage    99.54%   99.77%   +0.22%     
===========================================
  Files          104      113       +9     
  Lines         3278     3491     +213     
  Branches       385      407      +22     
===========================================
+ Hits          3263     3483     +220     
+ Misses           7        5       -2     
+ Partials         8        3       -5
Impacted Files Coverage Δ
csunplugged/general/views.py 100% <100%> (ø) ⬆️
csunplugged/config/urls.py 100% <0%> (ø) ⬆️
...nplugged/general/management/commands/updatedata.py 100% <0%> (ø) ⬆️
csunplugged/utils/LoaderFactory.py 100% <0%> (ø) ⬆️
csunplugged/search/views.py 100% <0%> (ø) ⬆️
...lugged/search/management/commands/rebuild_index.py 100% <0%> (ø) ⬆️
...classic/management/commands/_ClassicPagesLoader.py 100% <0%> (ø)
...ed/general/management/commands/loadgeneralpages.py 100% <0%> (ø)
csunplugged/general/search_indexes.py 100% <0%> (ø)
csunplugged/classic/apps.py 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2fe78...1d0ed00. Read the comment docs.

@saranglove saranglove changed the title Issue/878 Minor adjustments to navbar and homepage Feb 13, 2018
"""
# Call the base implementation first to get a context
context = super(GeneralIndexView, self).get_context_data(**kwargs)
# Add in a QuerySet of all the connected unit plans
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be removed sorry.

@@ -0,0 +1,8 @@
$(window).scroll(function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth investigating if this code should be within a document ready block: https://learn.jquery.com/using-jquery-core/document-ready/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the document.ready block creates a weird flash in the navbar when going from a non-homepage to the homepage.

background-color: rgba(0,0,0,0) !important;
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra newline.

Copy link
Member

@JackMorganNZ JackMorganNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have figured out it doesn't work on mobile, as drop down menu is also transparent. Will need to pick a solution for this, have several in mind so will discuss in person.

@JackMorganNZ JackMorganNZ merged commit 5b19db9 into develop Feb 15, 2018
@JackMorganNZ JackMorganNZ deleted the issue/878 branch February 15, 2018 04:03
@JackMorganNZ JackMorganNZ mentioned this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minor adjustments to navbar and homepage
2 participants