Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget instance locking needs to occur when the creator is opened. #1202

Closed
FrenjaminBanklin opened this issue Feb 20, 2019 · 2 comments
Closed

Widget instance locking needs to occur when the creator is opened. #1202

FrenjaminBanklin opened this issue Feb 20, 2019 · 2 comments
Assignees
@FrenjaminBanklin
Milestone
Ifrit (Dev 5)

Comments

@FrenjaminBanklin
Copy link
Contributor

Currently a widget instance is locked as soon as somebody clicks the 'Edit' button in the My Widgets page.

Not only does this mean that if somebody can't actually edit a widget (i.e. #1198) it'll still lock the widget, but it also means that going straight to the create url for a widget bypasses the lock check entirely.

Potentially the creator could have a new API call 'start_edit_session' or something which locks the widget, gets publish privileges, etc. all in one go.
@FrenjaminBanklin FrenjaminBanklin self-assigned this Feb 20, 2019
@FrenjaminBanklin
Copy link
Contributor Author

This should probably build on #1199.

FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 22, 2019
@FrenjaminBanklin
ucfopen#1202 Lock widget instances when the creator loads instead of …
c3a7388 
…when the 'edit' button is clicked.
This was referenced Feb 22, 2019
Open
Merged
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 25, 2019
@FrenjaminBanklin
ucfopen#1202 Tweak to name and output of widget instance edit verific…
cf73121 
…ation method. Added tests for new method. Fixed frontend warning not closing properly.
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Mar 12, 2019
@FrenjaminBanklin
ucfopen#1202 Following suggested changes, moved a few things around t…
c337de6 
…o fail earlier when necessary and added type suggestions to new/updated methods.
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Apr 3, 2019
@FrenjaminBanklin
ucfopen#1202 Minor doc code update to match vocabulary.
ee048d7
@clpetersonucf clpetersonucf mentioned this issue Apr 4, 2019
Merged
@iturgeon iturgeon added this to the Ifrit (~5) milestone Jun 3, 2019
@iturgeon
Copy link
Member

iturgeon commented Jun 3, 2019

Merged into Ifrit. Should ship soon, closing.

@iturgeon iturgeon closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrenjaminBanklin FrenjaminBanklin

Labels
None yet
Projects
None yet
Milestone
Ifrit (Dev 5)
Development

No branches or pull requests
2 participants
@iturgeon @FrenjaminBanklin