Skip to content

Install latest version of mock by default - #1

Merged
uchida merged 4 commits into
uchida:masterfrom
kostyrev:master
Apr 25, 2016
Merged

Install latest version of mock by default#1
uchida merged 4 commits into
uchida:masterfrom
kostyrev:master

Conversation

@kostyrev

Copy link
Copy Markdown
Contributor

As a role's user,
I want it to install the latest available version of software by default
so that I wasn't forced to remove the old package manually and apply the role.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
All committers have accepted the CLA.

@uchida

uchida commented Mar 19, 2016

Copy link
Copy Markdown
Owner

@kostyrevaa thank you for your contribution.
Use explicit version is appropriate and worth to merge.

However, I’m caring about tags in your request, --tags or --skip-tags are applied in a whole playbook and it’s hard to give consistent tag naming rule across ansible roles.
I prefer roles to be neutral with respect to tag naming, so I would like to avoid using tags inside ansible role.

@kostyrev

Copy link
Copy Markdown
Contributor Author

Hi!
I've removed those tags.

@uchida
uchida merged commit a727898 into uchida:master Apr 25, 2016
@uchida

uchida commented Apr 25, 2016

Copy link
Copy Markdown
Owner

Your request has merged, thanks @kostyrevaa.
version 0.1.2, includes this request, is available on ansible galaxy.

@uchida

uchida commented Apr 25, 2016

Copy link
Copy Markdown
Owner

After merged this pull request, I realised that using mock_config instead of mock_config_init seems better.
However it may break backward compatibility, so I will release 0.2.0 later (changes only minor version because currently this role in moratorium, 0.x.x, for semantic versioning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants