Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install latest version of mock by default #1

Merged
merged 4 commits into from Apr 25, 2016
Merged

Conversation

@kostyrev
Copy link
Contributor

@kostyrev kostyrev commented Mar 13, 2016

As a role's user,
I want it to install the latest available version of software by default
so that I wasn't forced to remove the old package manually and apply the role.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 13, 2016

CLA assistant check
All committers have accepted the CLA.

@uchida
Copy link
Owner

@uchida uchida commented Mar 19, 2016

@kostyrevaa thank you for your contribution.
Use explicit version is appropriate and worth to merge.

However, I’m caring about tags in your request, --tags or --skip-tags are applied in a whole playbook and it’s hard to give consistent tag naming rule across ansible roles.
I prefer roles to be neutral with respect to tag naming, so I would like to avoid using tags inside ansible role.

kostyrevaa added 2 commits Apr 24, 2016
@kostyrev
Copy link
Contributor Author

@kostyrev kostyrev commented Apr 24, 2016

Hi!
I've removed those tags.

@uchida uchida merged commit a727898 into uchida:master Apr 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@uchida
Copy link
Owner

@uchida uchida commented Apr 25, 2016

Your request has merged, thanks @kostyrevaa.
version 0.1.2, includes this request, is available on ansible galaxy.

@uchida
Copy link
Owner

@uchida uchida commented Apr 25, 2016

After merged this pull request, I realised that using mock_config instead of mock_config_init seems better.
However it may break backward compatibility, so I will release 0.2.0 later (changes only minor version because currently this role in moratorium, 0.x.x, for semantic versioning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants