Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CSS for Menu Items with Icons or Thumbnail support #51

Open
zkhalapyan opened this Issue Jan 4, 2012 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

zkhalapyan commented Jan 4, 2012

I am trying to add a menu item with an icon on it's left to the bottom of a standard text only menu, but the current support for embedding icons or thumbnails within menu items needs a more efficient and simpler solution.

Seems like the front page icon-menu solution is a bit of a hack : adding .menu-front class to the container menu, and hard-wiring various size icons to the background of the menu link items.

Wouldn't it be better to use an <img> tag within the menu item's <a> tag and encapsulate the CSS properties into a .menu-icon/menu-thumbnail class that will correctly shift the text to the right in order to allow space for the icon? This will allow mixed types of menu items within a single menu.

Also is it a feasible solution to require a size restriction on icon and thumbnail images to be used within menu items? See below example:

Icons: 16x16 (px)
Thumbnails: 80x80 (px)

@ghost ghost assigned ebollens and zkhalapyan Jan 4, 2012

Collaborator

ebollens commented Jan 30, 2012

Zorayr, what's the status on this? Are you going to commit something that implements this?

Contributor

zkhalapyan commented Jan 30, 2012

This is implemented within OHMAGE but not MWF. Just need to port it to a feature branch.

Collaborator

ebollens commented Apr 10, 2012

Reassigning this to 1.3.XX as it's not a priority for 1.3.00 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment