New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename descriptions tab to metadata #382

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@crowesn
Contributor

crowesn commented Sep 7, 2018

Fixes #368
Fixes #380

Override Hyrax en/es locale to rename Descriptions on new work form to Metadata.
Also added Spanish translation for top of workform help.

Changes proposed in this pull request:

  • Update config/locales/hyrax.en.yml
  • Update config/locales/hyrax.es.yml
  • Feature spec checking for presence of 'Metadata' on new work creation.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 7, 2018

Coverage Status

Coverage remained the same at 96.962% when pulling 745379e on feature/#368-rename-descriptions-tab into 7e170c5 on develop.

coveralls commented Sep 7, 2018

Coverage Status

Coverage remained the same at 96.962% when pulling 745379e on feature/#368-rename-descriptions-tab into 7e170c5 on develop.

@hortongn

This comment has been minimized.

Show comment
Hide comment
@hortongn

hortongn Sep 11, 2018

Member

@crowesn How did you get the Spanish translations?

Member

hortongn commented Sep 11, 2018

@crowesn How did you get the Spanish translations?

@crowesn

This comment has been minimized.

Show comment
Hide comment
@crowesn

crowesn Sep 11, 2018

Contributor
Contributor

crowesn commented Sep 11, 2018

@hortongn hortongn merged commit 9e681fb into develop Sep 12, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.962%
Details

@hortongn hortongn deleted the feature/#368-rename-descriptions-tab branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment