New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection license persistence #445

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@crowesn
Contributor

crowesn commented Oct 2, 2018

Fixes #438

Collection license form values weren't persisting due to single/multi value issue.
Add property override to local collection model and the problem is resolved.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 2, 2018

Coverage Status

Coverage decreased (-0.06%) to 96.922% when pulling 4eb06c0 on bug/#438-collection-license into 65b2a97 on develop.

coveralls commented Oct 2, 2018

Coverage Status

Coverage decreased (-0.06%) to 96.922% when pulling 4eb06c0 on bug/#438-collection-license into 65b2a97 on develop.

@hortongn hortongn self-assigned this Oct 3, 2018

@hortongn

This comment has been minimized.

Show comment
Hide comment
@hortongn

hortongn Oct 3, 2018

Member

@crowesn This now has a merge conflict because PR #439 also touched app/models/collection.rb. You can now remove your self.multiple? method since #439 already added it.

Member

hortongn commented Oct 3, 2018

@crowesn This now has a merge conflict because PR #439 also touched app/models/collection.rb. You can now remove your self.multiple? method since #439 already added it.

@crowesn crowesn removed the merge conflict label Oct 3, 2018

@crowesn

This comment has been minimized.

Show comment
Hide comment
@crowesn

crowesn Oct 3, 2018

Contributor

@hortongn this should be good to go.

Contributor

crowesn commented Oct 3, 2018

@hortongn this should be good to go.

@hortongn hortongn merged commit 89ecc9a into develop Oct 4, 2018

1 of 3 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 96.98%
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hortongn hortongn deleted the bug/#438-collection-license branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment