Add Helm chart #60
Merged
Add Helm chart #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,83 @@ | |||
| apiVersion: apiextensions.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Since you are targeting Helm 3, is there any reason you are installing CRD's from here instead of as they describe: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/
Basically there should be a crds directory where they live AND helm will NOT apply any updates to them after they are installed.
Is it that this method will install and update them each time?
Contributor
Author
There was a problem hiding this comment.
Ok, Nice comment. Fixed!
Contributor
|
@alexeyNsorokin Thanks for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team,
I'd like to propose a simple Helm chart for redis-operator deployment.
Of course there are some points to improve there.
This Helm chart is only for Helm v3. I've tested it on our company's k8s clusters. It works fine.
It should be noticed: security context definition for cluster crd does not work with the release version of the operator because of command for saving redis password to /etc directory.