Skip to content

fix(common): when response is not ok, fix nullpointer exception #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2022
Merged

fix(common): when response is not ok, fix nullpointer exception #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8dca4e
fix(common): if header is null, donot set requestId
fioncat Dec 6, 2022
f3c6a7d
fix(common): compile error
fioncat Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ucloud-sdk-java-common/src/main/java/cn/ucloud/common/transport/DefaultTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ public Response invoke(Request request, Class<? extends Response> clazz)
} catch (Exception e) {
throw new TransportException("http error", e);
}
String requestId = httpResponse.getLastHeader(HEADER_REQUEST_ID).getValue();

String requestId = "";
if (httpResponse.getLastHeader(HEADER_REQUEST_ID) != null) {
requestId = httpResponse.getLastHeader(HEADER_REQUEST_ID).getValue();
}

// check http status
StatusLine httpStatus = httpResponse.getStatusLine();
Expand Down