Permalink
Show file tree
Hide file tree
3 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
opj_t2_encode_packet(): fix potential write heap buffer overflow (#992)
- Loading branch information
Showing
2 changed files
with
24 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c535531There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Applying this patch to the stable openjpeg 2.2.0 release ends in a compile error.
Perhaps this is only valid for the master branch?
Can this patch be backported to stable release too, or can you release 2.2.1 which includes this fix?
Thankx.
c535531There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this patch depends on previous commits, including 9624b2f and 0b4fef6 , but I'm not sure they are self sufficient by themselves and wouldn't introduce regressions.
A 2.2.1 release should happen soon
c535531There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and even it that compiles, backporting "random" changesets is somewhat risky from a functionnality point of view. I strongly recommand you run the regression test suite with OPJ_NONCOMMERCIAL=YES ./tools/travis-ci/run.sh and compare the results before&after (there are some known failures depending on platforms, etc)