Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESTART and BYPASS encoding modes are broken #674

Closed
boxerab opened this issue Dec 26, 2015 · 4 comments
Closed

RESTART and BYPASS encoding modes are broken #674

boxerab opened this issue Dec 26, 2015 · 4 comments
Labels
duplicate
Projects
OPJ_OPTIM_ROUND1

Comments

@boxerab
Copy link
Contributor

boxerab commented Dec 26, 2015

i.e. lossless encoding with either mode produces a lossy encoded file

Simple test:

  1. lossless encode with command line flag -M 4
  2. decode and compare with original : non-zero MSE between two images
@boxerab
Copy link
Contributor Author

boxerab commented Mar 22, 2016

This is also true for BYPASS mode (M == 1)

@boxerab boxerab changed the title Lossless encoding using RESTART encoding mode is not actually lossless RESTART and BYPASS encoding modes are broken Mar 23, 2016
@boxerab
Copy link
Contributor Author

boxerab commented Mar 23, 2016

These modes have been broken for at least 6 years, probably forever.

@julienmalik julienmalik mentioned this issue Apr 22, 2016
Closed
@julienmalik
Copy link
Collaborator

julienmalik commented Apr 22, 2016 •
edited

By a strange coincidence, mode 1 and mode 4 are the only two modes who are generating the uninitialized read reported in #612. The others are valgrind-clean.

detonin added a commit that referenced this issue May 3, 2016
@detonin
update #612 #770 #674
51a51bd 
RESTART mode is now working, BYPASS still broken but much better
@detonin detonin mentioned this issue May 3, 2016
Closed
@boxerab boxerab closed this as completed Dec 29, 2016
@boxerab boxerab reopened this Dec 29, 2016
@boxerab boxerab mentioned this issue Feb 14, 2017
Closed
@xbarin02 xbarin02 mentioned this issue Feb 15, 2017
Closed
@detonin detonin added this to TO DO in OPJ_OPTIM_ROUND1 Mar 19, 2017
@rouault rouault mentioned this issue May 23, 2017
Closed
@rouault rouault moved this from TO DO to DOING in OPJ_OPTIM_ROUND1 Jun 7, 2017
rouault added a commit to uclouvain/openjpeg-data that referenced this issue Jun 9, 2017
@rouault
Update and add tests for fix for RESTART, BYPASS and PTERM coding opt…
be376b3 
…ions (uclouvain/openjpeg#674)
rouault added a commit to rouault/openjpeg that referenced this issue Jun 9, 2017
@rouault
T1: fix BYPASS/LAZY, TERMALL/RESTART and PTERM/ERTERM encoding modes. (…
81c5311 
…uclouvain#674)

There were a number of defects regarding when and how the termination of
passes had to done and the computation of their rate.
@rouault
Copy link
Collaborator

rouault commented Jun 13, 2017

Fixed per #949

@rouault rouault closed this as completed Jun 13, 2017
@rouault rouault moved this from DOING to DONE in OPJ_OPTIM_ROUND1 Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
OPJ_OPTIM_ROUND1
DONE
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boxerab @detonin @julienmalik @rouault