Api #11
Merged
Api #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SebCorbin Is it usefull yet to add pagination? |
SebCorbin
reviewed
Apr 16, 2021
api/views.py
Outdated
|
|
||
| class HistoryEntryListAPIView(ListAPIView): | ||
| serializer_class = HistoryEntryListSerializer | ||
| authentication_classes = [SessionAuthentication, ] |
There was a problem hiding this comment.
Do we open history entries to everyone (question asked in chat)?
There was a problem hiding this comment.
Pour les entrées d'historique, chacun doit implémenter sa propre vue (qui héritera d'une vue généraliste dans contrib\views.py) ==> Il faudra juste redéfinir la permission
|
Let's not paginate at the moment, even with 100 entries, it should be fast enough (and pagination would be hard on timelines) |
AL9000
commented
Apr 16, 2021
SebCorbin
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.