Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

Feature/update doi #576

Merged
merged 4 commits into from
Jan 10, 2019
Merged

Feature/update doi #576

merged 4 commits into from
Jan 10, 2019

Conversation

VivianChu
Copy link
Member

Fixes ucsdlib/damsrepo#73

Local Checklist

  • Tests written and passing locally?
  • Code style checked?
  • QA-ed locally?
  • Rebased with master branch?
  • Configuration updated (if needed)?
  • Documentation updated (if needed)?

What does this PR do?

Add update doi record function

Screenshots

  • Before DOI Update

beforedoiupdate2

-After DOI Update

afterdoiupdate2

-If there's doi, this message will be displayed.

successfulmsg

-If no DOI is minted, this error message will be displayed.

errordoiupdatemsg

@ucsdlib/developers - please review

Fix failed tests

Change update doi label
@coveralls
Copy link

coveralls commented Jan 8, 2019

Coverage Status

Coverage increased (+0.008%) to 66.764% when pulling 8b64794 on feature/update_doi into 1a48a59 on master.

@mcritchlow
Copy link
Member

quick question, the comment in the last screenshot is -If no DOI is minted, this error message will be displayed. I'm not clear on the language here i guess. if we're updating a DOI, then there is already a DOI identifier, right? So I'm wondering how you triggered the error you're demonstrating with an invalid identifier.

@VivianChu
Copy link
Member Author

@mcritchlow - The link for Mint DOI and Update DOI record is displayed for all records. However, if you click on Update DOI record link before clicking the Mint DOI link, then that error will be displayed. Or do think if I should hide the Update DOI record link unless that record has a DOI identifier?

@mcritchlow
Copy link
Member

@VivianChu Ah, I see. That makes sense.

I think if it's not too much trouble to hide the Update DOI link unless there is already a DOI associated with the record, that would be nice and avoid someone accidentally doing that.

I suppose likewise you could hide the Mint DOI link if the object already has a DOI?

@VivianChu
Copy link
Member Author

@mcritchlow - Sounds good. I'll make an update to hide the Mint DOI and Update DOI link. I'll keep you posted.

@VivianChu
Copy link
Member Author

@mcritchlow - The function has been updated to hide/show doi link. It has been deployed to staging. Here are the screen shots.
//DOI minted record. The Update DOI record link is displayed and the Mint DOI link is hidden.
updatedoi

//No DOI minted record. The Update DOI record link is hidden and the Mint DOI link is displayed.
nodoiid

Copy link
Member

@mcritchlow mcritchlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lsitu
Copy link
Member

lsitu commented Jan 10, 2019

👍

@lsitu lsitu merged commit 1a1b317 into master Jan 10, 2019
@lsitu lsitu deleted the feature/update_doi branch January 10, 2019 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants