-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Fix failed tests Change update doi label
e0e207b
to
4d5349f
Compare
quick question, the comment in the last screenshot is |
@mcritchlow - The link for Mint DOI and Update DOI record is displayed for all records. However, if you click on Update DOI record link before clicking the Mint DOI link, then that error will be displayed. Or do think if I should hide the Update DOI record link unless that record has a DOI identifier? |
@VivianChu Ah, I see. That makes sense. I think if it's not too much trouble to hide the Update DOI link unless there is already a DOI associated with the record, that would be nice and avoid someone accidentally doing that. I suppose likewise you could hide the Mint DOI link if the object already has a DOI? |
@mcritchlow - Sounds good. I'll make an update to hide the Mint DOI and Update DOI link. I'll keep you posted. |
@mcritchlow - The function has been updated to hide/show doi link. It has been deployed to staging. Here are the screen shots. //No DOI minted record. The Update DOI record link is hidden and the Mint DOI link is displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 |
Fixes ucsdlib/damsrepo#73
Local Checklist
master
branch?What does this PR do?
Add update doi record function
Screenshots
-After DOI Update
-If there's doi, this message will be displayed.
-If no DOI is minted, this error message will be displayed.
@ucsdlib/developers - please review