Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

Fixes #642 - Create conditional copyright boilerplate for RDCP. #692

Merged
merged 3 commits into from
Aug 7, 2019

Conversation

hweng
Copy link
Contributor

@hweng hweng commented Jul 22, 2019

Fixes #642

Local Checklist

  • Tests written and passing locally?
  • Code style checked?
  • QA-ed locally?
  • Rebased with master branch?
  • Configuration updated (if needed)?
  • Documentation updated (if needed)?

What does this PR do?

Create conditional copyright boilerplate, for objects with CC license for RDCP collection only.

Why are we doing this? Any context of related work?

References #642

@ucsdlib/developers - please review

Copy link
Member

@mcritchlow mcritchlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could go in as-is, though I have a couple of thoughts for consideration. So marking my review as Comment for now.

app/views/shared/fields/_copyright.html.erb Outdated Show resolved Hide resolved
app/views/shared/fields/_copyright.html.erb Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 22, 2019

Coverage Status

Coverage remained the same at 65.992% when pulling 91fffb6 on feature/copyright into d0cdbf8 on master.

Copy link
Member

@mcritchlow mcritchlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@VivianChu
Copy link
Member

👍

@VivianChu VivianChu merged commit fc68e1f into master Aug 7, 2019
@VivianChu VivianChu deleted the feature/copyright branch August 7, 2019 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create conditional copyright boilerplate, for objects with CC license
4 participants