Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #17 #22

Merged
merged 1 commit into from Apr 11, 2013
Merged

Fix issue #17 #22

merged 1 commit into from Apr 11, 2013

Conversation

Amorph
Copy link
Contributor

@Amorph Amorph commented Mar 29, 2013

Fix issue about double accuracy

@Amorph
Copy link
Contributor Author

Amorph commented Mar 29, 2013

Hm, my patch not work with C90 compiler.
I'll try to fix this

@LB--
Copy link
Member

LB-- commented Mar 29, 2013

I believe json_int_t is 64bit; it should be used here anyway.

@Amorph
Copy link
Contributor Author

Amorph commented Mar 29, 2013

json_int_t not work with C90 too, becouse don't have inttypes.h and any 64 bit number except double.
Current number parser, works with 64bit Int's thanks to some hacks. I'll try to split parsing float and integer numbers.

@LB--
Copy link
Member

LB-- commented Mar 29, 2013

Well, using json_int_t would allow it to compile under the travis build and most people would be able to compile it as 64 bits. It's just a suggestion.

@Amorph
Copy link
Contributor Author

Amorph commented Mar 29, 2013

Ok. Tomorrow I'll made changes.
Also I'm preparing simple json writer with full escaping and UTF8->to \uXXXX conversion

@Amorph
Copy link
Contributor Author

Amorph commented Apr 3, 2013

Updated commit

@jamesamcl
Copy link
Collaborator

Thanks, LGTM. What name would you like in the AUTHORS?

@Amorph
Copy link
Contributor Author

Amorph commented Apr 8, 2013

My name is Ivan Kozub.
What do you think about adding features like editing and printing?

@jamesamcl jamesamcl merged commit 652c908 into json-parser:master Apr 11, 2013
@jamesamcl
Copy link
Collaborator

I'm not sure about editing as we don't have a serializer, but I'd be happy to contribute to a more complete JSON suite incorporating json-parser.

Printing could be nice to have in json-parser, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants