New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update behaviours to reflect changes made in elixir 1.4 #231

Merged
merged 1 commit into from Dec 21, 2016

Conversation

Projects
None yet
2 participants
@alexandrubagu
Copy link
Contributor

alexandrubagu commented Dec 9, 2016

There were some warning when running elixir 1.4. I've test on elixir 1.3.4 an 1.4. All test return successfully

warning: the Behaviour module is deprecated. Instead of using this module, use the @callback and @macrocallback module attributes. See the documentation for Module for more information on these attributes
  lib/guardian/claim_validation.ex:12: (module)
  (elixir) src/elixir_compiler.erl:125: :elixir_compiler.dispatch_loaded/6
  (elixir) src/elixir_module.erl:191: :elixir_module.eval_form/6
  (elixir) src/elixir_module.erl:71: :elixir_module.do_compile/5
  (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6

warning: the Behaviour module is deprecated. Instead of using this module, use the @callback and @macrocallback module attributes. See the documentation for Module for more information on these attributes
  lib/guardian/hooks.ex:5: (module)
  (elixir) src/elixir_compiler.erl:125: :elixir_compiler.dispatch_loaded/6
  (elixir) src/elixir_module.erl:191: :elixir_module.eval_form/6
  (elixir) src/elixir_module.erl:71: :elixir_module.do_compile/5
  (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6

warning: the Behaviour module is deprecated. Instead of using this module, use the @callback and @macrocallback module attributes. See the documentation for Module for more information on these attributes
  lib/guardian/serializer.ex:9: (module)
  (elixir) src/elixir_compiler.erl:125: :elixir_compiler.dispatch_loaded/6
  (elixir) src/elixir_module.erl:191: :elixir_module.eval_form/6
  (elixir) src/elixir_module.erl:71: :elixir_module.do_compile/5
  (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6

@doomspork doomspork merged commit f1289eb into ueberauth:master Dec 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@doomspork

This comment has been minimized.

Copy link
Member

doomspork commented Dec 21, 2016

Thank you @alexandrubagu

Hanspagh added a commit to Hanspagh/guardian that referenced this pull request Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment