Ecto 2 1 update #36

Merged
merged 3 commits into from Jan 10, 2017

Projects

None yet

2 participants

@manukall
Contributor
manukall commented Jan 9, 2017

This fixes deprecation warnings introduces by Ecto 2.1.

I also changed the test migration name and location, because with the old name the migration wasn't run.

config/test.exs
@@ -17,3 +17,4 @@ config :guardian_db, GuardianDb.Test.Repo,
database: "guardian_db_test",
pool: Ecto.Adapters.SQL.Sandbox,
priv: "test/support"
+ priv: "priv/test"
@doomspork
doomspork Jan 10, 2017 Member

Do we need both :priv keys?

@doomspork
Member

Thank you @manukall! I only have one question with regards to the configuration.

@manukall
Contributor

@doomspork thanks for reviewing. the double priv keys were indeed an error. the one under priv/test is correct, as the ecto documentation states that migrations need to be under priv.

@doomspork
Member

Thank you @manukall 👍

@doomspork doomspork merged commit 568048d into ueberauth:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment