New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add extra params to callback_url #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @radzserg 👍
assert Ueberauth.Strategy.Helpers.callback_url(conn) == | ||
"https://www.example.com/auth/provider/callback" | ||
end | ||
|
||
test "callback_url forwarded protocol" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to remove this test?
@@ -14,7 +14,8 @@ defmodule UeberauthTest do | |||
end | |||
|
|||
test "simple callback phase" do | |||
conn = conn(:get, "/auth/simple/callback") |> SpecRouter.call(@opts) | |||
conn = conn(:get, "/auth/simple/callback") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind refactoring this bit? I need to setup Credo on the repos.
conn = :get
|> conn("/auth/simple/callback")
|> SpecRouter.call(@opts)
auth = conn.assigns.ueberauth_auth
@doomspork Done |
Thank you @radzserg 👍 |
I added ability to specify :callback_params in settings for strategies
then add this extra param to login/sign-up links
Tested on facebook twitter and VK strategies.