From 5c6292a281aa5dc3df58a2ddecdf9689a232a393 Mon Sep 17 00:00:00 2001 From: James Taber Date: Thu, 9 Feb 2023 12:50:19 +0100 Subject: [PATCH] fix(extension-link): Click handler opens selected link instead of clicked link --- packages/extension-link/src/helpers/clickHandler.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/extension-link/src/helpers/clickHandler.ts b/packages/extension-link/src/helpers/clickHandler.ts index 884628cf2f..6c3e7c9284 100644 --- a/packages/extension-link/src/helpers/clickHandler.ts +++ b/packages/extension-link/src/helpers/clickHandler.ts @@ -14,8 +14,11 @@ export function clickHandler(options: ClickHandlerOptions): Plugin { const attrs = getAttributes(view.state, options.type.name) const link = (event.target as HTMLElement)?.closest('a') - if (link && attrs.href) { - window.open(attrs.href, attrs.target) + const href = link?.href ?? attrs.href + const target = link?.target ?? attrs.target + + if (link && href) { + window.open(href, target) return true }