From fae596c6a784f05055b8f9dfada265f36e7777b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aldin=20Neziri=C4=87?= Date: Fri, 18 Aug 2023 15:08:23 +0200 Subject: [PATCH 1/2] prevent opening link when clicking on selection containing a link --- packages/extension-link/src/helpers/clickHandler.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/extension-link/src/helpers/clickHandler.ts b/packages/extension-link/src/helpers/clickHandler.ts index 5312881ca4..b20f4f9474 100644 --- a/packages/extension-link/src/helpers/clickHandler.ts +++ b/packages/extension-link/src/helpers/clickHandler.ts @@ -15,6 +15,9 @@ export function clickHandler(options: ClickHandlerOptions): Plugin { return false } + const eventTarget = event.target as HTMLElement; + if (eventTarget.nodeName !== 'A') return false; + const attrs = getAttributes(view.state, options.type.name) const link = (event.target as HTMLLinkElement) From 51ce85ad0eaac38a64257b38dac160c595a61dbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aldin=20Neziri=C4=87?= Date: Fri, 18 Aug 2023 16:16:04 +0200 Subject: [PATCH 2/2] Fix lint err --- packages/extension-link/src/helpers/clickHandler.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/extension-link/src/helpers/clickHandler.ts b/packages/extension-link/src/helpers/clickHandler.ts index b20f4f9474..23934f495e 100644 --- a/packages/extension-link/src/helpers/clickHandler.ts +++ b/packages/extension-link/src/helpers/clickHandler.ts @@ -15,8 +15,11 @@ export function clickHandler(options: ClickHandlerOptions): Plugin { return false } - const eventTarget = event.target as HTMLElement; - if (eventTarget.nodeName !== 'A') return false; + const eventTarget = event.target as HTMLElement + + if (eventTarget.nodeName !== 'A') { + return false + } const attrs = getAttributes(view.state, options.type.name) const link = (event.target as HTMLLinkElement)