New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve hankaku katakana conversion #51

Merged
merged 3 commits into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@lo48576
Copy link
Contributor

lo48576 commented Jan 23, 2018

Currently, some symbols such as "「" (left corner bracket) and "ー" (prolonged sound mark) are not automatically converted to half-width in hankaku-katakana mode.
For example, currently S a p o - t o C-q outputs "サポート", not "サポート".

Additionaly, "ヲ", "ヲ", "、" and "。" are not specified as henkan auto-start keywords.

This PR fixes these issues.

lo48576 added some commits Jan 23, 2018

Improve kana conversion table and add tests for hankaku-kana conversion
Added small-ka, small-ke, and some symbols used frequently in Japanese.

@lo48576 lo48576 changed the title "Feature/improve hankaku katakana conversion improve hankaku katakana conversion Jan 23, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 23, 2018

Coverage Status

Coverage increased (+0.05%) to 79.924% when pulling 2d3ae61 on lo48576:feature/improve-hankaku-katakana-conversion into 9ff1f89 on ueno:master.

@ueno

ueno approved these changes Jan 23, 2018

Copy link
Owner

ueno left a comment

Thank you the changes look fine.

_output.append_unichar (period);
string kana_period = Util.convert_by_input_mode(
period.to_string(),
kana_mode.to_input_mode());

This comment has been minimized.

@ueno

ueno Jan 23, 2018

Owner

I guess you could simply cast it to InputMode with (InputMode)kana_mode, as the values in these enums are compatible: https://github.com/ueno/libskk/blob/master/libskk/context.vala#L40

@lo48576 lo48576 force-pushed the lo48576:feature/improve-hankaku-katakana-conversion branch from 1d2a7e6 to 2d3ae61 Jan 23, 2018

@lo48576 lo48576 closed this Jan 23, 2018

@lo48576 lo48576 deleted the lo48576:feature/improve-hankaku-katakana-conversion branch Jan 23, 2018

@lo48576 lo48576 restored the lo48576:feature/improve-hankaku-katakana-conversion branch Jan 23, 2018

@lo48576

This comment has been minimized.

Copy link
Contributor

lo48576 commented Jan 23, 2018

Sorry, I made mistake on executing git...

@lo48576 lo48576 reopened this Jan 23, 2018

@ueno ueno merged commit 56f4123 into ueno:master Jan 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 79.924%
Details

@lo48576 lo48576 deleted the lo48576:feature/improve-hankaku-katakana-conversion branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment