New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let key release events pass through #52

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
3 participants
@lo48576
Copy link
Contributor

lo48576 commented Jan 27, 2018

Some web pages and web applications requires key release events (even when focuset to input box) to work correctly.

For example, google's keyword suggestions requires up/down keys' release event to select candidates, and Mastodon's search box in web UI requires Enter key's release event to start searching.
But current libskk filters out those key release events, and those web pages cannot operated with fcitx-skk.

This patch let key release events pass through, and let those applications (which requires both key release events and text inputs at same time) work correctly.

@lo48576 lo48576 force-pushed the lo48576:fix/let-key-release-events-passthrough branch from bd6ef61 to 545830c Jan 27, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 27, 2018

Coverage Status

Coverage increased (+0.01%) to 79.934% when pulling 651392b on lo48576:fix/let-key-release-events-passthrough into d5df162 on ueno:master.

@lo48576 lo48576 changed the title Let key release events pass through [WIP] Let key release events pass through Jan 27, 2018

@lo48576 lo48576 force-pushed the lo48576:fix/let-key-release-events-passthrough branch 2 times, most recently from 5f722c5 to 51f19ba Jan 27, 2018

@lo48576 lo48576 force-pushed the lo48576:fix/let-key-release-events-passthrough branch from 51f19ba to 651392b Jan 27, 2018

@lo48576

This comment has been minimized.

Copy link
Contributor

lo48576 commented Jan 27, 2018

Ideally, the release event should be ignored only when the corresponding key press event is consumed.
But it seems very hard with the current implementation, because each state handlers expect only key press events and does not remember or log the event is consumed or unhandled...

Currently this patch let key release events pass through when dict_edit_level() == 0, but I'm not sure if it would cause unexpected side-effect.
I think (and wish) many applications which process text input will use key press event (not key release event), so this change would be less likely to cause problem.

@lo48576 lo48576 changed the title [WIP] Let key release events pass through Let key release events pass through Jan 27, 2018

@ueno ueno merged commit 57ecea8 into ueno:master Jun 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 79.934%
Details

@lo48576 lo48576 deleted the lo48576:fix/let-key-release-events-passthrough branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment