New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use libxkbcommon to resolve keysyms #54
Conversation
@lo48576 would you like to review this? |
Thanks, I'll try this patch soon (tomorrow if possible). |
Thank you! |
With this patch (and fcitx-skk), Control key is wrongrly handled.
|
That would cause incompatible behavior when we switched to libxkbcommon to resolve keysyms: #54 (comment)
4c3f130
to
93e7373
Compare
Thank you for the report and I am sorry for the long delay. Indeed, it seems that unassigned keysyms were treated as commit in some cases; it should be fixed in 10555a2. |
Tested |
Thank you for testing; let's merge it then. |
That would cause incompatible behavior when we switched to libxkbcommon to resolve keysyms: #54 (comment)
Although it's still a bit ugly, this implements what I outlined in:
#47 (review)