Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use libxkbcommon to resolve keysyms #54

Merged
merged 4 commits into from Aug 20, 2018
Merged

Conversation

ueno
Copy link
Owner

@ueno ueno commented Jul 2, 2018

Although it's still a bit ugly, this implements what I outlined in:
#47 (review)

@ueno
Copy link
Owner Author

ueno commented Jul 10, 2018

@lo48576 would you like to review this?

@lo48576
Copy link
Contributor

lo48576 commented Jul 10, 2018

Thanks, I'll try this patch soon (tomorrow if possible).

@ueno
Copy link
Owner Author

ueno commented Jul 10, 2018

Thank you!

@lo48576
Copy link
Contributor

lo48576 commented Jul 11, 2018

With this patch (and fcitx-skk), Control key is wrongrly handled.
(Shift key seems to behave as same, so I think there is an issue around modifier key handling.)

  1. Ctrl key confirms preedit
    input: A o SPC Control_L (not at skk command, in real world)
    expected: ▼青 (not confirmed)
    got: (confirmed)

  2. Ctrl key removes incomplete alphabet at hiragana mode
    input: H o h Control_L (in real world)
    expected: ▽ほh (not confirmed)
    got: ▽ほ (not confirmed)

  3. After Ctrl key, normal input is ignored?
    input: H o h Control_L a a a a a (in real world)
    expected: ▽ほはああああ
    got: ▽ほ
    At this state, Backspace key correctly removes character .

@ueno
Copy link
Owner Author

ueno commented Aug 20, 2018

Thank you for the report and I am sorry for the long delay. Indeed, it seems that unassigned keysyms were treated as commit in some cases; it should be fixed in 10555a2.

@lo48576
Copy link
Contributor

lo48576 commented Aug 20, 2018

Tested "Muhenkan" and "Escape" bindings on my environment, and they worked as I expected. 😄

@ueno
Copy link
Owner Author

ueno commented Aug 20, 2018

Thank you for testing; let's merge it then.

@ueno ueno merged commit 54415da into master Aug 20, 2018
ueno added a commit that referenced this pull request Aug 20, 2018
That would cause incompatible behavior when we switched to
libxkbcommon to resolve keysyms:
#54 (comment)
@ueno ueno deleted the wip/dueno/xkbcommon branch September 15, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants