Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist does not work for a specific file type (Jupyter notebook, "*.ipynb"). #636

Closed
anlif opened this issue Aug 19, 2019 · 2 comments

Comments

@anlif
Copy link

commented Aug 19, 2019

I'm opening this issue because:

  • [ x] I'll report a bug
  • I'll propose a new feature

Description

Blacklist does not work for a specific file type (Jupyter notebook, "*.ipynb").

Failure Information (for bugs)

Steps to Reproduce

  1. Add the Blacklist pattern "*.ipynb"
  2. Open a Jupyter Notebook with extension ".ipynb"
  3. Observe that the plugin is not disabled

System configuration

  • Operating system: Ubuntu 18.04
  • Firefox version: 68.0.2 (64-bit)
  • Vim-Vixen version: 0.23

Console logs

@ueokande

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

@anlif
Sorry to late replying.

Blacklist treats "*.ipynb" as a domain name matching. So it matches with foo.ipynb and bar.ipynb/index.html, but not foo.example.com/v1/fizzbuzz.ipynb.

Please try wildcards with path separator: */*.ipynb

@anlif

This comment has been minimized.

Copy link
Author

commented Sep 5, 2019

This works! Thank you.

@anlif anlif closed this Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.