From 8e29c0d8c5cdc87d0a7358e090af864c4f03b1a8 Mon Sep 17 00:00:00 2001 From: yangjie01 Date: Tue, 30 Jan 2024 08:44:34 -0800 Subject: [PATCH] [SPARK-46921][BUILD] Move `ProblemFilters` that do not belong to `defaultExcludes` to `v40excludes` ### What changes were proposed in this pull request? This pr just move `ProblemFilters` that do not belong to `defaultExcludes` to `v40excludes`. ### Why are the changes needed? We should not arbitrarily add entries to `defaultExcludes`, as it represents never participating in the mima check ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Mima check passed ### Was this patch authored or co-authored using generative AI tooling? No Closes #44952 from LuciferYang/SPARK-46921. Authored-by: yangjie01 Signed-off-by: Dongjoon Hyun --- project/MimaExcludes.scala | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala index 43723742be97b..64c5599919a6c 100644 --- a/project/MimaExcludes.scala +++ b/project/MimaExcludes.scala @@ -59,7 +59,25 @@ object MimaExcludes { // [SPARK-45762][CORE] Support shuffle managers defined in user jars by changing startup order ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SparkEnv.this"), // [SPARK-46480][CORE][SQL] Fix NPE when table cache task attempt - ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.TaskContext.isFailed") + ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.TaskContext.isFailed"), + + // SPARK-43299: Convert StreamingQueryException in Scala Client + ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.streaming.StreamingQueryException"), + + // SPARK-45856: Move ArtifactManager from Spark Connect into SparkSession (sql/core) + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.apply"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.userId"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.sessionId"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.copy"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.copy$default$3"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.this"), + ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.storage.CacheId$"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.apply"), + + // SPARK-46410: Assign error classes/subclasses to JdbcUtils.classifyException + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.JdbcDialect.classifyException"), + // [SPARK-464878][CORE][SQL] (false alert). Invalid rule for StringType extension. + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.types.StringType.this") ) // Default exclude rules @@ -92,24 +110,6 @@ object MimaExcludes { ProblemFilters.exclude[Problem]("org.sparkproject.spark_protobuf.protobuf.*"), ProblemFilters.exclude[Problem]("org.apache.spark.sql.protobuf.utils.SchemaConverters.*"), - // SPARK-43299: Convert StreamingQueryException in Scala Client - ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.streaming.StreamingQueryException"), - - // SPARK-45856: Move ArtifactManager from Spark Connect into SparkSession (sql/core) - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.apply"), - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.userId"), - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.sessionId"), - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.copy"), - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.copy$default$3"), - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.this"), - ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.storage.CacheId$"), - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.CacheId.apply"), - - // SPARK-46410: Assign error classes/subclasses to JdbcUtils.classifyException - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.JdbcDialect.classifyException"), - // [SPARK-464878][CORE][SQL] (false alert). Invalid rule for StringType extension. - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.types.StringType.this"), - (problem: Problem) => problem match { case MissingClassProblem(cls) => !cls.fullName.startsWith("org.sparkproject.jpmml") && !cls.fullName.startsWith("org.sparkproject.dmg.pmml")