Set log level at runtime #1056
Merged
Set log level at runtime #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,8 @@ int main(int argc, char *argv[]) | |||
| "(http://www.opengeosys.org) " | |||
| "Distributed under a Modified BSD License. " | |||
| "See accompanying file LICENSE.txt or " | |||
| "http://www.opengeosys.org/project/license", | |||
| "http://www.opengeosys.org/project/license\n" | |||
| "version: " + BaseLib::BuildInfo::git_describe, | |||
| ' ', | |||
| BaseLib::BuildInfo::git_describe); | |||
There was a problem hiding this comment.
Just checking. Will the version number displayed only once?
There was a problem hiding this comment.
Yes, the second BaseLib::BuildInfo::git_describe is only shown when running ogs --version.
| LOGOG_SHUTDOWN(); | ||
| } | ||
|
|
||
| void SetFormatter(std::unique_ptr<logog::Formatter> formatter) |
There was a problem hiding this comment.
There should be && added. Otherwise it will not work if you pass non-temporaries to that method. ✅
|
But in general I like the idea! |
|
👍 |
See LogogSetup.h for possible values. tests-target has a log level of warn.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-lcommand line arguments to OGS cli and the testrunner. Possible values:none,error,warn,info,debug,all.make testslog-level is nowwarn(this suppresses verbose logging in recent Jenkins builds).