Fix usage of optional<T const&>. #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The called getPropertyVector<T>() did not return
a const reference optional, but an optional<T&>.
With boost 1.61 this conversion is no longer possible.
Fixes #1383
|
Send you a PR for discussion. |
|
Is fine on Mac OS Clang! 👍 |
|
👍 |
bilke
added a commit
to bilke/ogs
that referenced
this pull request
Sep 14, 2016
Follow-up on ufz#1385.
bilke
added a commit
to bilke/ogs
that referenced
this pull request
Sep 14, 2016
Follow-up on ufz#1385.
|
I know it's already merged, but isn't an optional reference semantically equal to a pointer? |
Yonghui56
pushed a commit
to Yonghui56/ogs
that referenced
this pull request
Sep 20, 2016
Follow-up on ufz#1385.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The called
getPropertyVector<T>()did not return an optional to a const reference (there are two versions of that function), but anoptional<T&>.With boost 1.61 this conversion is no longer possible.
Fixes #1383