Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Time stepping frame work #1803
requested review from
and removed request for
May 23, 2017
Many comments, but no fundamental issues.
Most importantly I think:
MathLib::VecNormType::INVALIDshould be avoided as a marker for a special case.
- Maybe we should talk (in a greater round) about how to treat norms close to zero in general.
7 times, most recently
Jun 16, 2017
Jun 30, 2017
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.