New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Added option OGS_EIGEN_INITIALIZE_MATRICES_BY_NAN. #1917

Merged
merged 4 commits into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@bilke
Member

bilke commented Aug 15, 2017

Defaults to ON.

Set EIGEN_NO_AUTOMATIC_RESIZING macro as well.
See https://eigen.tuxfamily.org/dox/TopicPreprocessorDirectives.html.

Related to #1909.

@bilke bilke requested a review from endJunction Aug 15, 2017

@endJunction

This comment has been minimized.

Member

endJunction commented Aug 15, 2017

Perfect! It immediately catched a bug! 🎆
I'll provide a fix shortly.

@chleh

This comment has been minimized.

Contributor

chleh commented Aug 16, 2017

👍

@bilke

This comment has been minimized.

Member

bilke commented Aug 17, 2017

@endJunction I have added Eigen 3.3.4 as a Conan package: bilke/conan-eigen3@6e8d433

@endJunction endJunction force-pushed the bilke:eigen-macros branch from 1aa72eb to 3db8dd7 Aug 21, 2017

@endJunction

This comment has been minimized.

Member

endJunction commented Aug 21, 2017

I've removed the EIGEN_NO_AUTOMATIC_RESIZING option for now, so the PR can be merged soon.
The automatic resizing option needs more work and I was not able to debug the behaviour seen on travis on my local machine.

@endJunction endJunction force-pushed the bilke:eigen-macros branch 2 times, most recently from 0af9301 to daba0e9 Aug 21, 2017

@endJunction endJunction force-pushed the bilke:eigen-macros branch from daba0e9 to dced105 Aug 25, 2017

@endJunction

This comment has been minimized.

Member

endJunction commented Aug 25, 2017

Needs one more review and can be merged if OK.

@chleh

chleh approved these changes Aug 25, 2017

👍 As already said 9 days ago.

@endJunction

This comment has been minimized.

Member

endJunction commented Aug 28, 2017

OK. While nobody is listening, I'll merge it quietly ;)

@endJunction endJunction merged commit a24fc3a into ufz:master Aug 28, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@endJunction endJunction deleted the bilke:eigen-macros branch Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment