Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More analyzers (cppcheck, clang-tidy, iwyu) #2078

Merged
merged 7 commits into from Feb 15, 2018

Conversation

Projects
None yet
2 participants
@bilke
Copy link
Member

bilke commented Feb 14, 2018

Added more analyzers to a master-only subjob:

See example output. Unfortunately the warnings are not reported / summarized somewhere at the moment. CDash implements that and is under investigation ...

Other changes:

To discuss:

iwyu suggests to include

#include <logog/include/macro.hpp>                     // for INFO, WARN
#include <logog/include/message.hpp>                   // for Message

instead of of just logog/include/logog.hpp. Should we do it like this, otherwise we have to somehow silence this warning.

@bilke bilke added the please review label Feb 14, 2018

@bilke bilke requested a review from endJunction Feb 14, 2018

@@ -0,0 +1,3 @@
---
# Disable all checks, one check has to be enabled (hack)

This comment has been minimized.

@endJunction

endJunction Feb 14, 2018

Member

why the hack?

This comment has been minimized.

@bilke

bilke Feb 14, 2018

Author Member

If there is no enabled check clang-tidy (at least in the way it is invoked by CMake) prints out its usage instructions.

This comment has been minimized.

@bilke

bilke Feb 14, 2018

Author Member

I did not find another way to specify that this folder should be ignored.

This comment has been minimized.

@endJunction

endJunction Feb 14, 2018

Member

I see. I neither do know. ;(
Just add this comment to the "hack", so we are not wondering why...

@endJunction

This comment has been minimized.

Copy link
Member

endJunction commented Feb 14, 2018

"somehow silence." I don't remember the options, but iwyu can be told to use that specific include file instead of the others... Maybe over a config file. Or enforce keeping that include, smth like:

#include "logog.h" // IWYU_special_keep_this_always.

@bilke bilke force-pushed the bilke:analyzers branch from 90235ef to 6f1a9d4 Feb 14, 2018

@endJunction endJunction merged commit 0cbfc9a into ufz:master Feb 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@bilke bilke deleted the bilke:analyzers branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.