Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition boundary meshes #2178

Merged
merged 20 commits into from Aug 14, 2018

Conversation

Projects
None yet
3 participants
@endJunction
Copy link
Member

endJunction commented Aug 9, 2018

Follow up of #2177 (MeshLib vertex point vtk conversion).

Further refactorings (mainly free-functions) to the NodeWiseMeshPartitioner.
Extension of the partmesh tool to partition boundary meshes (with ctests).

@endJunction endJunction force-pushed the endJunction:PartitionBoundaryMeshes branch 2 times, most recently from ac776e1 to 0806420 Aug 9, 2018

{
auto& partition = partitions[part_id];
INFO("Processing partition: %d", part_id);
{ // processPartition(part_id, is_mixed_high_order_linear_elems)

This comment has been minimized.

@TomFischer

TomFischer Aug 13, 2018

Member

Is this comment necessary?

@@ -633,7 +782,8 @@ void getElementIntegerVariables(

for (long i = 0; i < nn; i++)
{
elem_info[counter++] = local_node_ids.at(elem.getNodeIndex(i));
auto const& n = *elem.getNode(i);
elem_info[counter++] = local_node_ids.at(n.getID());

This comment has been minimized.

@TomFischer

TomFischer Aug 13, 2018

Member

I wonder why is the access into local_node_ids via the at() method?

This comment has been minimized.

@endJunction

endJunction Aug 13, 2018

Author Member

For safety. In a map, accessed via op[], a default value would be created.

This comment has been minimized.

@endJunction

endJunction Aug 13, 2018

Author Member

Note to myself: local_node_ids could be passed as const& maybe...

This comment has been minimized.

@TomFischer

TomFischer Aug 13, 2018

Member

Thanks for the explanation. I overlook that local_node_ids is a map.

@TomFischer
Copy link
Member

TomFischer left a comment

Looks good! 👍

@endJunction endJunction force-pushed the endJunction:PartitionBoundaryMeshes branch from 0806420 to 416016c Aug 13, 2018

@wenqing
Copy link
Member

wenqing left a comment

👍

@endJunction endJunction force-pushed the endJunction:PartitionBoundaryMeshes branch from 416016c to 3a39b20 Aug 14, 2018

@endJunction endJunction merged commit b11da2c into ufz:master Aug 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:PartitionBoundaryMeshes branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.