Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove writing of xsd header in XML files #2198

Merged
merged 4 commits into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@bilke
Copy link
Member

bilke commented Aug 28, 2018

As the existence of this line:

xsi:noNamespaceSchemaLocation="http://www.opengeosys.org/images/xsd/OpenGeoSysXXX.xsd"

in OpenGeoSys XML files still (see #2169, #2136 and 57821a9) leads to validation errors it is no longer written to OpenGeoSys generated XML files. Local validation (either in source or also when using Tools from precompiled zip-archives, e.g. from the website) should still work. The only functionality which will be lost is if you open a XML file standalone in an editor (which supports validation) the file is not validated.

For existing XML files it is strongly advised to remove the line manually to prevent validation errors with current OGS tools.

The XSD files are still served from opengeosys.org/images/xsd/.. for refercence and are now automatically updated (by simply using symlinks).

@bilke bilke added the please review label Aug 28, 2018

@bilke bilke requested review from endJunction and rinkk Aug 28, 2018

@bilke bilke force-pushed the bilke:remove-xsd-in-xml branch 2 times, most recently from 5f4a133 to 1a2c989 Aug 29, 2018

@bilke

This comment has been minimized.

Copy link
Member Author

bilke commented Aug 29, 2018

@endJunction Failed unit test on Windows?

[ RUN      ] ShapeFunctionTest/10.PartitionOfUnity

e:\jenkins\workspace\8-b3ql3ysxj6\thirdparty\autocheck\include\autocheck\reporter.hpp(91): error: Value of: AUTOCHECK_SUCCESS

  Actual: false

Expected: true

Falsifiable, after 80 tests:

([-0.36244,-0.103832,0.272988,])



[  FAILED  ] ShapeFunctionTest/10.PartitionOfUnity, where TypeParam = class NumLib::ShapeHex20 (1 ms)
@@ -42,7 +42,6 @@ bool BoostXmlGmlInterface::readFile(const std::string &fname)

// ignore attributes related to XML schema
doc->ignoreConfigAttribute("xmlns:xsi");
doc->ignoreConfigAttribute("xsi:noNamespaceSchemaLocation");

This comment has been minimized.

@chleh

chleh Sep 10, 2018

Collaborator

Removing that line will probably lead to errors with existing files that contain that attribute. Maybe better leave in order to not frustrate users?

This comment has been minimized.

@bilke

bilke Sep 11, 2018

Author Member

Good point, thanks!

@bilke bilke force-pushed the bilke:remove-xsd-in-xml branch from 1a2c989 to 5361929 Sep 11, 2018

@bilke bilke force-pushed the bilke:remove-xsd-in-xml branch from 5361929 to 5302814 Sep 12, 2018

@bilke bilke force-pushed the bilke:remove-xsd-in-xml branch from 5302814 to b48a98f Sep 12, 2018

@endJunction endJunction merged commit 687848a into ufz:master Sep 12, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction referenced this pull request Sep 12, 2018

Merged

Python BCs: Hertz Contact test #2184

1 of 1 task complete

@bilke bilke deleted the bilke:remove-xsd-in-xml branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.