Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM/HM/LIE-HM interpolated pressure #2228

Merged
merged 9 commits into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@endJunction
Copy link
Member

endJunction commented Sep 30, 2018

Move LIE/HM interpolate_pressure to NumLib::interpolateToHigherOrderNodes.

Use in RichardsMechanics and HydroMechanics processes.

@endJunction endJunction force-pushed the endJunction:RMInterpolatedPressure branch from 92d57ea to 9c83e6a Sep 30, 2018

@chleh

chleh approved these changes Oct 1, 2018

Copy link
Collaborator

chleh left a comment

only minor comments.

///
/// The base nodes' values are copied. For each higher order node the shape
/// matrices are evaluated for the lower order element (the base nodes), and
/// used for the the scalar quantity interpolation.

This comment has been minimized.

@chleh

chleh Oct 1, 2018

Collaborator

Maybe it should be mentioned that the node_values belong to a scalar field.

{
// Evaluated at higher order nodes' coordinates.
fe.template computeShapeFunctions<ShapeMatrixType::N>(
NaturalCoordinates<HigherOrderMeshElementType>::coordinates[n]

This comment has been minimized.

@chleh

chleh Oct 1, 2018

Collaborator

The HigherOrderMeshElementType is the "true" type of element, isn't it? Maybe that could be commented
or asserted: assert(dynamic_cast<HigherOrderMeshElementType*>(&element));.

.data(),
shape_matrices, GlobalDim, is_axially_symmetric);

std::size_t const global_index = element.getNodeIndex(n);

This comment has been minimized.

@chleh

chleh Oct 1, 2018

Collaborator

Does that work with domain decomposition?

This comment has been minimized.

@endJunction

endJunction Oct 1, 2018

Author Member

I think so, because the node numbering is local for each partition, and so are the mesh properties...

@endJunction endJunction merged commit 6cd1259 into ufz:master Oct 1, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:RMInterpolatedPressure branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.